USHIFT-1287, USHIFT-1315: prepare EC 1 build#1892
USHIFT-1287, USHIFT-1315: prepare EC 1 build#1892openshift-merge-robot merged 3 commits intoopenshift:mainfrom
Conversation
|
@dhellmann: This pull request references USHIFT-1315 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
* quay.io/openshift-release-dev/ocp-release:4.14.0-ec.1-x86_64 * quay.io/openshift-release-dev/ocp-release:4.14.0-ec.1-aarch64 * registry.access.redhat.com/lvms4/lvms-operator-bundle:v4.12
8f1db71 to
4828ff2
Compare
| # version is checked in the prep step below. | ||
| # | ||
| BuildRequires: golang | ||
| # DO NOT REMOVE |
There was a problem hiding this comment.
I think we can remove DO NO REMOVE statements. The comment seems to be enough on explaining why we keep it there.
|
@dhellmann , please also update this line in |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhellmann, ggiguash The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test images |
|
@dhellmann: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/assign @ggiguash @pacevedom