Skip to content

USHIFT-1287, USHIFT-1315: prepare EC 1 build#1892

Merged
openshift-merge-robot merged 3 commits intoopenshift:mainfrom
dhellmann:USHIFT-1315-golang-dependency
Jun 7, 2023
Merged

USHIFT-1287, USHIFT-1315: prepare EC 1 build#1892
openshift-merge-robot merged 3 commits intoopenshift:mainfrom
dhellmann:USHIFT-1315-golang-dependency

Conversation

@dhellmann
Copy link
Contributor

  • restore build dependency on golang
  • update image references to 4.14 EC 1 build

/assign @ggiguash @pacevedom

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 6, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 6, 2023

@dhellmann: This pull request references USHIFT-1315 which is a valid jira issue.

Details

In response to this:

  • restore build dependency on golang
  • update image references to 4.14 EC 1 build

/assign @ggiguash @pacevedom

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from copejon and pliurh June 6, 2023 18:32
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2023
dhellmann added 2 commits June 6, 2023 14:40
* quay.io/openshift-release-dev/ocp-release:4.14.0-ec.1-x86_64
* quay.io/openshift-release-dev/ocp-release:4.14.0-ec.1-aarch64
* registry.access.redhat.com/lvms4/lvms-operator-bundle:v4.12
@dhellmann dhellmann force-pushed the USHIFT-1315-golang-dependency branch from 8f1db71 to 4828ff2 Compare June 6, 2023 18:40
# version is checked in the prep step below.
#
BuildRequires: golang
# DO NOT REMOVE
Copy link
Contributor

@ggiguash ggiguash Jun 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove DO NO REMOVE statements. The comment seems to be enough on explaining why we keep it there.

@ggiguash
Copy link
Contributor

ggiguash commented Jun 7, 2023

@dhellmann , please also update this line in configure-vm.sh script to install the golang RPM. Otherwise, when installing the devenv, we won't be able to build an RPM.

@ggiguash
Copy link
Contributor

ggiguash commented Jun 7, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 7, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, ggiguash

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD bd00d8e and 2 for PR HEAD 4544c49 in total

@dhellmann
Copy link
Contributor Author

/test images

@openshift-merge-robot openshift-merge-robot merged commit 3c91bab into openshift:main Jun 7, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 7, 2023

@dhellmann: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/microshift-e2e-arm 4544c49 link false /test microshift-e2e-arm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants