USHIFT-1083 Backup data if system was healthy#1874
USHIFT-1083 Backup data if system was healthy#1874openshift-merge-robot merged 7 commits intoopenshift:mainfrom
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci
bot
added
the
approved
pmtk
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
dhellmann
left a comment
dhellmann
left a comment
There was a problem hiding this comment.
I have a couple of nits, but those can be addressed in another PR. I'll leave it open to give others on the team a chance to read it but we should be able to approve it Monday.
packaging/greenboot/green.sh
Outdated
| exit 0 | ||
| fi | ||
|
|
||
| mkdir -p /var/lib/microshift-backups |
There was a problem hiding this comment.
We should make sure to add this directory to the RPM spec.
There was a problem hiding this comment.
I'm not sure we should be adding database directories to the RPM spec. They should not be deleted after RPMs are uninstalled.
There was a problem hiding this comment.
That's a good point. I'd say we want to keep it. @dhellmann WDYT?
There was a problem hiding this comment.
Does listing the directory, without its content, in the spec cause it to be deleted when the RPM is removed?
There was a problem hiding this comment.
After some quick investigation it looks like uninstall removes files that are specified in %files so I think what we have is okay
pkg/admin/prerun/prerun.go
Outdated
| return err | ||
| } | ||
| if !exists { | ||
| klog.InfoS("Boot health information is missing - skipping backup") |
There was a problem hiding this comment.
We may end up changing this later when we support storage migration on an RPM-based system. Let's leave this return here for now and think about it when we enable that mode later.
|
/hold addressing changes in .go |
openshift-ci
bot
added
the
do-not-merge/hold
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/test microshift-e2e |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhellmann, pmtk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
@pmtk: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
4 participants
No description provided.