Skip to content

USHIFT-1268: add linter for robotframework files#1820

Merged
openshift-merge-robot merged 2 commits intoopenshift:mainfrom
dhellmann:USHIFT-1268-add-robotframework-linter
May 26, 2023
Merged

USHIFT-1268: add linter for robotframework files#1820
openshift-merge-robot merged 2 commits intoopenshift:mainfrom
dhellmann:USHIFT-1268-add-robotframework-linter

Conversation

@dhellmann
Copy link
Contributor

@dhellmann dhellmann commented May 18, 2023

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 18, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 18, 2023 •
edited by openshift-ci bot
Loading

@dhellmann: This pull request references USHIFT-1268 which is a valid jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from ggiguash and pliurh May 18, 2023 21:09
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 18, 2023
@dhellmann
Copy link
Contributor Author

dhellmann commented May 18, 2023

/assign @jogeo @pacevedom @chiragkyal

ggiguash
ggiguash reviewed May 19, 2023
View reviewed changes
@ggiguash
Copy link
Contributor

ggiguash commented May 19, 2023 •
edited
Loading

@dhellmann, looks great except for one consistency nit.
Please, note that the new shell scripts do not pass shell verify checks, so minor adjustements are required.

@dhellmann dhellmann force-pushed the USHIFT-1268-add-robotframework-linter branch 3 times, most recently from eef7533 to 51fa5ec Compare May 20, 2023 16:53
@ggiguash
Copy link
Contributor

ggiguash commented May 21, 2023

/retest

@dhellmann
Copy link
Contributor Author

dhellmann commented May 21, 2023

I think this PR needs openshift/release#37815 to bring in a newer Python 3.

@dhellmann
Copy link
Contributor Author

dhellmann commented May 24, 2023

/test verify

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 24, 2023
@dhellmann dhellmann force-pushed the USHIFT-1268-add-robotframework-linter branch from 51fa5ec to 56c15ff Compare May 24, 2023 21:36
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 24, 2023
@dhellmann dhellmann force-pushed the USHIFT-1268-add-robotframework-linter branch 5 times, most recently from b08dcd5 to 8cab7c9 Compare May 25, 2023 19:50
pacevedom
pacevedom reviewed May 25, 2023
View reviewed changes
@dhellmann dhellmann force-pushed the USHIFT-1268-add-robotframework-linter branch 2 times, most recently from 51eb6a4 to 071d75e Compare May 25, 2023 20:38
dhellmann added 2 commits May 25, 2023 17:44
@dhellmann
USHIFT-1268: add robocop linter for robotframework files
6cd1c55 
Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
@dhellmann
USHIFT-1268: update robotframework files for linter
ec7239c 
Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
@dhellmann dhellmann force-pushed the USHIFT-1268-add-robotframework-linter branch from 071d75e to ec7239c Compare May 25, 2023 21:44
@dhellmann
Copy link
Contributor Author

dhellmann commented May 25, 2023

Rebased again after #1840 merged.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 26, 2023

@dhellmann: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openshift-conformance-reduced-arm ec7239c link false /test e2e-openshift-conformance-reduced-arm
ci/prow/microshift-e2e-arm ec7239c link false /test microshift-e2e-arm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ggiguash
Copy link
Contributor

ggiguash commented May 26, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 26, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, ggiguash

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 5ac09fc into openshift:main May 26, 2023
This was referenced Nov 14, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pliurh pliurh Awaiting requested review from pliurh

2 more reviewers

@pacevedom pacevedom pacevedom left review comments

@ggiguash ggiguash ggiguash left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jogeo jogeo

@chiragkyal chiragkyal

@pacevedom pacevedom

@ggiguash ggiguash

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@dhellmann @openshift-ci-robot @ggiguash @pacevedom @jogeo @openshift-merge-robot @chiragkyal