Skip to content

[WIP] do not merge#1750

Closed
copejon wants to merge 3 commits intoopenshift:release-4.13from
copejon:ushift-1201-configure-plus-selinux
Closed

[WIP] do not merge#1750
copejon wants to merge 3 commits intoopenshift:release-4.13from
copejon:ushift-1201-configure-plus-selinux

Conversation

@copejon
Copy link
Contributor

@copejon copejon commented May 2, 2023

  • manually backport configure-vm.sh from main to 4.13 so CI will skip dependency installation
  • release-4.13 specifically disables selinux on rhel 9.1, so re-add the logic to the configure script
  • remove version specifier for container-selinux

copejon and others added 3 commits May 1, 2023 12:45
… logic to the configure script

Signed-off-by: Jon Cope <jcope@redhat.com>
We depend on cri-o and can rely on it to pull in any specific version
needed.  Currently neither cri-o nor podman specify a minimum version.
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 2, 2023

@copejon: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[WIP] do not merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 2, 2023
@openshift-ci openshift-ci bot requested review from ggiguash and stlaz May 2, 2023 14:46
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: copejon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 2, 2023
@copejon
Copy link
Contributor Author

copejon commented May 2, 2023

/retest

@copejon
Copy link
Contributor Author

copejon commented May 2, 2023

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 2, 2023
@copejon
Copy link
Contributor Author

copejon commented May 2, 2023

/retest

@copejon copejon closed this May 2, 2023
@copejon copejon deleted the ushift-1201-configure-plus-selinux branch May 2, 2023 16:44
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 2, 2023

@copejon: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openshift-conformance-reduced d2abfd7 link true /test e2e-openshift-conformance-reduced

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants