Skip to content

USHIFT-1201 Backport configure-vm.sh to 4.13#1742

Merged
openshift-merge-robot merged 2 commits intoopenshift:release-4.13from
copejon:ushift-1201-backport-dev-script
May 2, 2023
Merged

USHIFT-1201 Backport configure-vm.sh to 4.13#1742
openshift-merge-robot merged 2 commits intoopenshift:release-4.13from
copejon:ushift-1201-backport-dev-script

Conversation

@copejon
Copy link
Copy Markdown
Contributor

@copejon copejon commented May 1, 2023

Relates to USHIFT-1201

Transitioning CI to AWS in openshift/release#38877 is broken on release-4.13 due to the fact that on the release-4.13 version of configure-vm.sh, build dependencies are installed by default. This is producing an error on the RHEL 9.2 instance in AWS related to git package dependencies:

sudo dnf install -y git cockpit make golang jq selinux-policy-devel rpm-build jq bash-completion
# ... omiited ...
Error: [Errno 2] No such file or directory: '/var/cache/dnf/rhel-9-appstream-beta-rhui-rpms-ad06c8f61df035e2/packages/git-core-2.39.1-1.el9.x86_64.rpm' 

Back porting the more recent version will bring in changes that will condition the above command based on a CLI flag (--no-build-deps), which will skip the unnecessary deps install in CI.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented May 1, 2023

@copejon: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

USHIFT-1201 Backport configure-vm.sh to 4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from benluddy and pmtk May 1, 2023 17:53
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 1, 2023
@copejon
Copy link
Copy Markdown
Contributor Author

copejon commented May 1, 2023

/retest

1 similar comment
@copejon
Copy link
Copy Markdown
Contributor Author

copejon commented May 1, 2023

/retest

@copejon
Copy link
Copy Markdown
Contributor Author

copejon commented May 1, 2023

Current failures are a result of the service-ca container fail to come up due to what looks like selinux permissions:

> $ oc logs -n openshift-service-ca pod/service-ca-7754867754-c27hs service-ca-controller
exec container process `/usr/bin/service-ca-operator`: Operation not permitted 

Copy link
Copy Markdown
Contributor

@dhellmann dhellmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label May 1, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 1, 2023
@copejon
Copy link
Copy Markdown
Contributor Author

copejon commented May 2, 2023

/retest

@copejon
Copy link
Copy Markdown
Contributor Author

copejon commented May 2, 2023

/pj-rehearse max

@dhellmann
Copy link
Copy Markdown
Contributor

/label bugzilla/valid-bug

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 2, 2023
copejon added 2 commits May 2, 2023 16:22
… logic to the configure script

Signed-off-by: Jon Cope <jcope@redhat.com>
@copejon copejon force-pushed the ushift-1201-backport-dev-script branch from 4a3c9f1 to 733f7e0 Compare May 2, 2023 21:22
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 2, 2023
@dhellmann
Copy link
Copy Markdown
Contributor

/lgtm
/label bugzilla/valid-bug

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 2, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented May 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: copejon, dhellmann

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented May 2, 2023

@copejon: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jogeo
Copy link
Copy Markdown
Contributor

jogeo commented May 2, 2023

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 2, 2023
@openshift-merge-robot openshift-merge-robot merged commit 357f023 into openshift:release-4.13 May 2, 2023
@copejon copejon deleted the ushift-1201-backport-dev-script branch July 26, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.