Skip to content

USHIFT-1043: ignore case when looking at logging level#1657

Merged
openshift-merge-robot merged 1 commit intoopenshift:mainfrom
dhellmann:USHIFT-1043-logging-config-robustness
Apr 14, 2023
Merged

USHIFT-1043: ignore case when looking at logging level#1657
openshift-merge-robot merged 1 commit intoopenshift:mainfrom
dhellmann:USHIFT-1043-logging-config-robustness

Conversation

@dhellmann
Copy link
Contributor

Don't require the user to capitalize the log level name correctly.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 11, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 11, 2023

@dhellmann: This pull request references USHIFT-1043 which is a valid jira issue.

Details

In response to this:

Don't require the user to capitalize the log level name correctly.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from copejon and ggiguash April 11, 2023 19:53
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2023
@dhellmann
Copy link
Contributor Author

/assign @eggfoobar

@dhellmann dhellmann force-pushed the USHIFT-1043-logging-config-robustness branch from cc8a32c to 4567ff3 Compare April 11, 2023 21:38
@pacevedom
Copy link
Contributor

/test e2e-openshift-conformance-reduced

1 similar comment
@dhellmann
Copy link
Contributor Author

/test e2e-openshift-conformance-reduced

@dhellmann dhellmann force-pushed the USHIFT-1043-logging-config-robustness branch from 4567ff3 to 147be22 Compare April 13, 2023 20:23
Don't require the user to capitalize the log level name correctly.
@dhellmann dhellmann force-pushed the USHIFT-1043-logging-config-robustness branch from 147be22 to d61d725 Compare April 13, 2023 21:34
@eggfoobar
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, eggfoobar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [dhellmann,eggfoobar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 14, 2023

@dhellmann: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants