OCPBUGS-11395: Remove stale kubeconfigs

[pacevedom]

Remove any kubeconfig that is not part of the hostname or SAN values in configuration.

Which issue(s) this PR addresses:

Closes #

[openshift-ci-robot]

@pacevedom: This pull request references Jira Issue OCPBUGS-11395, which is invalid:

• expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Remove any kubeconfig that is not part of the hostname or SAN values in configuration.

Which issue(s) this PR addresses:

Closes #

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[pacevedom]

/retest

[dhellmann]

Maybe instead of logging a list here, the loop below could log right before it tries to remove each item? That would make the logs easier to read and would fit with the "unit of work" style logging. https://docs.openstack.org/oslo.log/latest/user/guidelines.html#overall-logging-principles

[pacevedom]

Didnt know about this guide, it is done now.

[dhellmann]

This is a good candidate for an automated test. Do we have the parts in place to add a test like that in this PR, or is the work to make that possible still in progress?

[pacevedom]

This is a good candidate for an automated test. Do we have the parts in place to add a test like that in this PR, or is the work to make that possible still in progress?

We could make it but not on this PR until #1557 merges. That way we can include it in a new e2e test that does not need another VM in CI.

[dhellmann]

This is a good candidate for an automated test. Do we have the parts in place to add a test like that in this PR, or is the work to make that possible still in progress?

We could make it but not on this PR until #1557 merges. That way we can include it in a new e2e test that does not need another VM in CI.

If the cleanup function took a directory name as argument, we could have some tests for it in the unit test framework.

[pacevedom]

This is a good candidate for an automated test. Do we have the parts in place to add a test like that in this PR, or is the work to make that possible still in progress?

We could make it but not on this PR until #1557 merges. That way we can include it in a new e2e test that does not need another VM in CI.

If the cleanup function took a directory name as argument, we could have some tests for it in the unit test framework.

Done

[pacevedom]

/test e2e-loadbalancer-smoke-test

[openshift-ci]

@pacevedom: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[pacevedom]

/jira refresh

[openshift-ci-robot]

@pacevedom: This pull request references Jira Issue OCPBUGS-11395, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jogeo

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dhellmann]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, pacevedom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [dhellmann,pacevedom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@pacevedom: Jira Issue OCPBUGS-11395: All pull requests linked via external trackers have merged:

• openshift/microshift#1643

Jira Issue OCPBUGS-11395 has been moved to the MODIFIED state.

Details

In response to this:

Remove any kubeconfig that is not part of the hostname or SAN values in configuration.

Which issue(s) this PR addresses:

Closes #

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.