USHIFT-1061: auto config generator#1639
USHIFT-1061: auto config generator#1639openshift-merge-robot merged 13 commits intoopenshift:mainfrom
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@eggfoobar: This pull request references USHIFT-1061 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci
bot
added
the
approved
eggfoobar
force-pushed
the
ushift-1061-auto-config-generator
branch
2 times, most recently
from
59838b9 to
2efdf57
Compare
dhellmann
left a comment
dhellmann
left a comment
There was a problem hiding this comment.
I like the direction this is going better than earlier versions. I have a few questions/comments inline about details. The actual YAML generator is pretty small, but could use some comments as an aid to future maintainers.
eggfoobar
force-pushed
the
ushift-1061-auto-config-generator
branch
from
2efdf57 to
dd99b59
Compare
dhellmann
left a comment
dhellmann
left a comment
There was a problem hiding this comment.
This is looking really good! I have a few questions inline.
dhellmann
left a comment
dhellmann
left a comment
There was a problem hiding this comment.
I like this version. We mentioned a few improvements in comment threads, but those can come later. Remove the hold when you're ready.
/lgtm
eggfoobar
force-pushed
the
ushift-1061-auto-config-generator
branch
from
b576ab3 to
4e55618
Compare
eggfoobar
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
eggfoobar
force-pushed
the
ushift-1061-auto-config-generator
branch
from
768e970 to
3cb5677
Compare
|
/test microshift-e2e-arm |
added tool to convert config crd to yaml wwith comments and kubebuilder syntax Signed-off-by: ehila <ehila@redhat.com>
Signed-off-by: ehila <ehila@redhat.com>
Signed-off-by: ehila <ehila@redhat.com>
Signed-off-by: ehila <ehila@redhat.com>
Signed-off-by: ehila <ehila@redhat.com>
Signed-off-by: ehila <ehila@redhat.com>
Signed-off-by: ehila <ehila@redhat.com>
Signed-off-by: ehila <ehila@redhat.com>
Signed-off-by: ehila <ehila@redhat.com>
Signed-off-by: ehila <ehila@redhat.com>
Signed-off-by: ehila <ehila@redhat.com>
moved wording to config-gen for the tool ran make vendor-etcd removed header info from generated config yaml Signed-off-by: ehila <ehila@redhat.com>
Signed-off-by: ehila <ehila@redhat.com>
eggfoobar
force-pushed
the
ushift-1061-auto-config-generator
branch
from
3cb5677 to
30d711c
Compare
|
/lgtm |
|
/hold give @pmtk a chance to look at this |
openshift-ci
bot
added
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhellmann, eggfoobar The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
@eggfoobar: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
5 participants
Which issue(s) this PR addresses:
This PR adds automatic generation of our config from the struct, we then are able to use go generate to update both our default yaml as well as our document yaml to keep things in sync with minimal effort and the source of truth being our source struct.