Skip to content

rebase-4.13.0-0.nightly-2023-04-01-062001_amd64-2023-04-01_arm64-2023-03-30#1612

Merged
openshift-merge-robot merged 10 commits intorelease-4.13from
rebase-4.13.0-0.nightly-2023-04-01-062001_amd64-2023-04-01_arm64-2023-03-30
Apr 4, 2023
Merged

rebase-4.13.0-0.nightly-2023-04-01-062001_amd64-2023-04-01_arm64-2023-03-30#1612
openshift-merge-robot merged 10 commits intorelease-4.13from
rebase-4.13.0-0.nightly-2023-04-01-062001_amd64-2023-04-01_arm64-2023-03-30

Conversation

@microshift-rebase-script
Copy link
Contributor

@microshift-rebase-script microshift-rebase-script bot commented Apr 3, 2023 •
edited
Loading

amd64: 4.13.0-0.nightly-2023-04-01-062001
arm64: 4.13.0-0.nightly-arm64-2023-03-30-050636
prow job: https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-openshift-microshift-release-4.13-rebase-on-nightlies/1643116487071764480

/label tide/merge-method-squash

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 3, 2023

@microshift-rebase-script[bot]: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

rebase-4.13.0-0.nightly-2023-04-01-062001_amd64-2023-04-01_arm64-2023-03-30

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Apr 3, 2023
@openshift-ci openshift-ci bot requested a review from mangelajo April 3, 2023 05:26
@ggiguash
Copy link
Contributor

ggiguash commented Apr 3, 2023

/retest

2 similar comments
@ggiguash
Copy link
Contributor

ggiguash commented Apr 3, 2023

/retest

@ggiguash
Copy link
Contributor

ggiguash commented Apr 3, 2023

/retest

@dhellmann dhellmann changed the title rebase-4.13.0-0.nightly-2023-04-01-062001_amd64-2023-04-01_arm64-2023-03-30 OCPBUGS-10568: rebase-4.13.0-0.nightly-2023-04-01-062001_amd64-2023-04-01_arm64-2023-03-30 Apr 3, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 3, 2023

@microshift-rebase-script[bot]: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

OCPBUGS-10568: rebase-4.13.0-0.nightly-2023-04-01-062001_amd64-2023-04-01_arm64-2023-03-30

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 3, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 3, 2023

@microshift-rebase-script[bot]: This pull request references Jira Issue OCPBUGS-10568, which is invalid:

  • expected the bug to target the "4.13.0" version, but it targets "4.14.0" instead
  • expected Jira Issue OCPBUGS-10568 to depend on a bug targeting a version in 4.14.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

amd64: 4.13.0-0.nightly-2023-04-01-062001
arm64: 4.13.0-0.nightly-arm64-2023-03-30-050636
prow job: https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-openshift-microshift-release-4.13-rebase-on-nightlies/1642754018461618176

/label tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dhellmann dhellmann changed the title OCPBUGS-10568: rebase-4.13.0-0.nightly-2023-04-01-062001_amd64-2023-04-01_arm64-2023-03-30 OCPBUGS-11317: rebase-4.13.0-0.nightly-2023-04-01-062001_amd64-2023-04-01_arm64-2023-03-30 Apr 3, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 3, 2023

@microshift-rebase-script[bot]: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

OCPBUGS-11317: rebase-4.13.0-0.nightly-2023-04-01-062001_amd64-2023-04-01_arm64-2023-03-30

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 3, 2023

@microshift-rebase-script[bot]: This pull request references Jira Issue OCPBUGS-11317, which is invalid:

  • expected the bug to target the "4.13.0" version, but it targets "4.14.0" instead
  • expected dependent Jira Issue OCPBUGS-10568 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

amd64: 4.13.0-0.nightly-2023-04-01-062001
arm64: 4.13.0-0.nightly-arm64-2023-03-30-050636
prow job: https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-openshift-microshift-release-4.13-rebase-on-nightlies/1642754018461618176

/label tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dhellmann
OCPBUGS-11317: migrate to using Lease for leader election
c9dca03 
The cluster-kube-controller-manager-operator changed the way it
manages leader election for kube-controller-manager, so the
configuration of the KCM is different than the unit tests
expect. Update the unit tests.
@dhellmann dhellmann force-pushed the rebase-4.13.0-0.nightly-2023-04-01-062001_amd64-2023-04-01_arm64-2023-03-30 branch from 00e8f1c to c9dca03 Compare April 3, 2023 20:38
@dhellmann
Copy link
Contributor

dhellmann commented Apr 3, 2023

/jira refresh

1 similar comment
@dhellmann
Copy link
Contributor

dhellmann commented Apr 3, 2023

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 3, 2023

@dhellmann: This pull request references Jira Issue OCPBUGS-11317, which is invalid:

  • expected dependent Jira Issue OCPBUGS-10568 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead
  • expected dependent Jira Issue OCPBUGS-10568 to target a version in 4.14.0, but it targets "4.13.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Apr 3, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, microshift-rebase-script[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 3, 2023
@dhellmann dhellmann added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 3, 2023
@dhellmann
Copy link
Contributor

dhellmann commented Apr 3, 2023

I've manually updated the labels on this PR to try to work around the fact that the bug is linked up to another project.

@dhellmann
Copy link
Contributor

dhellmann commented Apr 3, 2023

/retest-required

@microshift-rebase-script microshift-rebase-script bot changed the title OCPBUGS-11317: rebase-4.13.0-0.nightly-2023-04-01-062001_amd64-2023-04-01_arm64-2023-03-30 rebase-4.13.0-0.nightly-2023-04-01-062001_amd64-2023-04-01_arm64-2023-03-30 Apr 4, 2023
@microshift-rebase-script
Copy link
Contributor Author

microshift-rebase-script bot commented Apr 4, 2023

Rebase job updated the branch
amd64: 4.13.0-0.nightly-2023-04-01-062001
arm64: 4.13.0-0.nightly-arm64-2023-03-30-050636
prow job: https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-openshift-microshift-release-4.13-rebase-on-nightlies/1643116487071764480

/label tide/merge-method-squash

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 4, 2023

@microshift-rebase-script[bot]: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Retaining the bugzilla/valid-bug label as it was manually added.

Details

In response to this:

rebase-4.13.0-0.nightly-2023-04-01-062001_amd64-2023-04-01_arm64-2023-03-30

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 4, 2023

@microshift-rebase-script[bot]: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Retaining the bugzilla/valid-bug label as it was manually added.

Details

In response to this:

rebase-4.13.0-0.nightly-2023-04-01-062001_amd64-2023-04-01_arm64-2023-03-30

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 4, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 4, 2023

@microshift-rebase-script[bot]: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Retaining the jira/valid-bug label as it was manually added.

Details

In response to this:

amd64: 4.13.0-0.nightly-2023-04-01-062001
arm64: 4.13.0-0.nightly-arm64-2023-03-30-050636
prow job: https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-openshift-microshift-release-4.13-rebase-on-nightlies/1643116487071764480

/label tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 4, 2023

@microshift-rebase-script[bot]: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Retaining the jira/valid-bug label as it was manually added.

Details

In response to this:

amd64: 4.13.0-0.nightly-2023-04-01-062001
arm64: 4.13.0-0.nightly-arm64-2023-03-30-050636
prow job: https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-openshift-microshift-release-4.13-rebase-on-nightlies/1643116487071764480

/label tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ggiguash
Copy link
Contributor

ggiguash commented Apr 4, 2023

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 4, 2023

@microshift-rebase-script[bot]: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pacevedom
Copy link
Contributor

pacevedom commented Apr 4, 2023

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 4, 2023
@openshift-merge-robot openshift-merge-robot merged commit 38dcb09 into release-4.13 Apr 4, 2023
@openshift-merge-robot openshift-merge-robot deleted the rebase-4.13.0-0.nightly-2023-04-01-062001_amd64-2023-04-01_arm64-2023-03-30 branch April 4, 2023 08:56
@copejon copejon mentioned this pull request May 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggiguash ggiguash Awaiting requested review from ggiguash

@pmtk pmtk Awaiting requested review from pmtk

@mangelajo mangelajo Awaiting requested review from mangelajo

Assignees

@dhellmann dhellmann

@mffiedler mffiedler

@jhou1 jhou1

@zhaozhanqi zhaozhanqi

@jogeo jogeo

@xingxingxia xingxingxia

@anuragthehatter anuragthehatter

@wangke19 wangke19

@pacevedom pacevedom

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.