USHIFT-913: fix vendoring microshift in etcd/#1404
USHIFT-913: fix vendoring microshift in etcd/#1404openshift-merge-robot merged 3 commits intoopenshift:mainfrom
Conversation
|
@pmtk: This pull request references USHIFT-913 which is a valid jira issue. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/hold |
4b45442 to
55ff7a6
Compare
|
/unhold |
|
@pmtk: This pull request references USHIFT-913 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Commits are logically separated, but not functional without each other (all commits on main should be buildable) |
|
/lgtm |
55ff7a6 to
dc81c7b
Compare
|
@pmtk: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dusk125, pmtk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes
etcd/go.mod'sreplaceby removing unnecessary/fromgithub.com/openshift/microshift.This will result in
go mod vendorto copy microshift's code from the local directory. Previouslyetcd/vendor/github.com/openshift/microshift/pkg/configwas not kept up to date (rebase.sh didn't handled it because it didn't have the rebase command) and missing latest changes and posing challenges when updatingMicroShiftConfigand using updated version inmicroshift-etcd.