Skip to content

[release-4.12] OCPBUGS-7467: add configurable KAS advertise address#1360

Merged
openshift-merge-robot merged 5 commits intoopenshift:release-4.12from
openshift-cherrypick-robot:cherry-pick-1298-to-release-4.12
Feb 14, 2023
Merged

[release-4.12] OCPBUGS-7467: add configurable KAS advertise address#1360
openshift-merge-robot merged 5 commits intoopenshift:release-4.12from
openshift-cherrypick-robot:cherry-pick-1298-to-release-4.12

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Feb 13, 2023

This is an automated cherry-pick of #1298

/assign dhellmann

@pacevedom
USHIFT-716: KAS advertise address match the service network ip
6fe5a1b 
Adds an internal IP to kubernetes service. Pods will use an internal
IP to connect to KAS, while external clients will use the node IP.
Solves ambiguity problem when selecting which certificate to return
to a client, based on the destination IP (KAS).
Configures the service IP to the loopback interface so that the
endpoint slice for kubernetes service matches the same IP.
@pacevedom
USHIFT-716: add config options to alter KAS advertise address
a9b49e6 
To follow service CIDR configuration options, and to allow forcing
a different IP, a new configuration parameter is introduced. This
will come in handy when setting extra nodes.
Also excludes the node IP in the external serving certificate if
the KAS advertise address matches the node IP.
@pacevedom
USHIFT-716: Default KAS advertise address to follow service CIDR
e036609 
Defaults KAS advertise address to always follow the service CIDR from
configuration. If this CIDR is changed before starting MicroShift, the
KAS advertise address (and therefore the secondary IP to lo interface)
will be in that range.
@pacevedom
USHIFT-716: avoid interface address add when not default
2902095 
Avoid adding the secondary IP to lo interface when KAS advertise
address has been forced to an IP in a different range than service
network CIDR.
@pacevedom
USHIFT-716: New service to configure network with KAS address
aacf9e0 
Use a new service to configure loopback interface in the node if
required by the KAS advertise address. Kube apiserver service will
depend on this one before starting.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 13, 2023
Merged
@openshift-ci openshift-ci bot requested review from mangelajo and oglok February 13, 2023 20:26
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 13, 2023

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dhellmann
Copy link
Contributor

dhellmann commented Feb 13, 2023

/approve
/lgtm
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Feb 13, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2023
@jogeo
Copy link
Contributor

jogeo commented Feb 14, 2023

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 14, 2023
@dhellmann
Copy link
Contributor

dhellmann commented Feb 14, 2023

/retitle [release-4.12] OCPBUGS-7467: add configurable KAS advertise address

@openshift-ci openshift-ci bot changed the title [release-4.12] USHIFT-716: add configurable KAS advertise address [release-4.12] OCPBUGS-7467: add configurable KAS advertise address Feb 14, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 14, 2023

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.12] OCPBUGS-7467: add configurable KAS advertise address

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 14, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 14, 2023

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-7467, which is invalid:

  • expected Jira Issue OCPBUGS-7467 to depend on a bug targeting a version in 4.13.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #1298

/assign dhellmann

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dhellmann
Copy link
Contributor

dhellmann commented Feb 14, 2023

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 14, 2023

@dhellmann: This pull request references Jira Issue OCPBUGS-7467, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead
  • expected Jira Issue OCPBUGS-7467 to depend on a bug targeting a version in 4.13.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dhellmann
Copy link
Contributor

dhellmann commented Feb 14, 2023

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 14, 2023

@dhellmann: This pull request references Jira Issue OCPBUGS-7467, which is invalid:

  • expected Jira Issue OCPBUGS-7467 to depend on a bug targeting a version in 4.13.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dhellmann
Copy link
Contributor

dhellmann commented Feb 14, 2023

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 14, 2023

@dhellmann: This pull request references Jira Issue OCPBUGS-7467, which is invalid:

  • expected Jira Issue OCPBUGS-7467 to depend on a bug targeting a version in 4.13.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dhellmann
Copy link
Contributor

dhellmann commented Feb 14, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 14, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 14, 2023

@dhellmann: This pull request references Jira Issue OCPBUGS-7467, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.z) matches configured target version for branch (4.12.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-7442 is in the state Release Pending (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-7442 targets the "4.13.0" version, which is one of the valid target versions: 4.13.0
  • bug has dependents

Requesting review from QA contact:
/cc @jogeo

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from jogeo February 14, 2023 14:57
@openshift-merge-robot openshift-merge-robot merged commit 581e12e into openshift:release-4.12 Feb 14, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 14, 2023

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-7467 has been moved to the MODIFIED state.

Details

In response to this:

This is an automated cherry-pick of #1298

/assign dhellmann

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mangelajo mangelajo Awaiting requested review from mangelajo

@oglok oglok Awaiting requested review from oglok

@jogeo jogeo Awaiting requested review from jogeo

Assignees

@dhellmann dhellmann

@mffiedler mffiedler

@jhou1 jhou1

@zhaozhanqi zhaozhanqi

@jogeo jogeo

@xingxingxia xingxingxia

@anuragthehatter anuragthehatter

@wangke19 wangke19

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.