Skip to content

USHIFT-870: do not require kubeconfig to run rebase script#1359

Merged
openshift-merge-robot merged 1 commit intoopenshift:mainfrom
dhellmann:USHIFT-870-rebase-without-oc-credentials
Feb 14, 2023
Merged

USHIFT-870: do not require kubeconfig to run rebase script#1359
openshift-merge-robot merged 1 commit intoopenshift:mainfrom
dhellmann:USHIFT-870-rebase-without-oc-credentials

Conversation

@dhellmann
Copy link
Contributor

Ensure the namespace is set for namespace-scoped manifests when
copying them. Copy the cluster-scoped manifests without modifying
them.

Running this using last_rebase.sh produced minimal changes in indentation
in the LVMS manifests.

Ensure the namespace is set for namespace-scoped manifests when
copying them.  Copy the cluster-scoped manifests without modifying
them.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 13, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 13, 2023

@dhellmann: This pull request references USHIFT-870 which is a valid jira issue.

Details

In response to this:

Ensure the namespace is set for namespace-scoped manifests when
copying them. Copy the cluster-scoped manifests without modifying
them.

Running this using last_rebase.sh produced minimal changes in indentation
in the LVMS manifests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dhellmann
Copy link
Contributor Author

/assign @copejon @pmtk

@openshift-ci openshift-ci bot requested review from copejon and fzdarsky February 13, 2023 19:21
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 13, 2023

@dhellmann: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pmtk
Copy link
Member

pmtk commented Feb 14, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants