Skip to content

USHIFT-790: always take image version from content when rebasing#1353

Merged
openshift-merge-robot merged 1 commit intoopenshift:mainfrom
dhellmann:USHIFT-790-take-version-from-image-content
Feb 13, 2023
Merged

USHIFT-790: always take image version from content when rebasing#1353
openshift-merge-robot merged 1 commit intoopenshift:mainfrom
dhellmann:USHIFT-790-take-version-from-image-content

Conversation

@dhellmann
Copy link
Contributor

Instead of parsing the image name to find the version and date, use
the image data we have already extracted.

Instead of parsing the image name to find the version and date, use
the image data we have already extracted.
@openshift-ci-robot
Copy link

@dhellmann: No Jira issue with key SHIFT-790 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

Details

In response to this:

Instead of parsing the image name to find the version and date, use
the image data we have already extracted.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from oglok and pacevedom February 10, 2023 22:05
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2023
@dhellmann dhellmann changed the title SHIFT-790: always take image version from content when rebasing USHIFT-790: always take image version from content when rebasing Feb 10, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 10, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 10, 2023

@dhellmann: This pull request references USHIFT-790 which is a valid jira issue.

Details

In response to this:

Instead of parsing the image name to find the version and date, use
the image data we have already extracted.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dhellmann
Copy link
Contributor Author

I was able to manually run the script far enough to get it to create the branch with the right name and apply several changes to it. It eventually failed trying to rebase the lvms stuff because I didn't have a local cluster running so the oc create commands failed.

@pmtk
Copy link
Member

pmtk commented Feb 13, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 13, 2023

@dhellmann: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants