Skip to content

USHIFT-377: make sure all files from assets/ are handled by rebase#1351

Merged
openshift-merge-robot merged 1 commit intoopenshift:mainfrom
pmtk:rebase/recipe-simple-presubmit
Feb 15, 2023
Merged

USHIFT-377: make sure all files from assets/ are handled by rebase#1351
openshift-merge-robot merged 1 commit intoopenshift:mainfrom
pmtk:rebase/recipe-simple-presubmit

Conversation

@pmtk
Copy link
Member

@pmtk pmtk commented Feb 10, 2023

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 10, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 10, 2023

@pmtk: This pull request references USHIFT-377 which is a valid jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pmtk
Copy link
Member Author

pmtk commented Feb 10, 2023

Builds on top of #1347

@pmtk
Copy link
Member Author

pmtk commented Feb 10, 2023

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 10, 2023
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 10, 2023

@pmtk: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openshift-conformance-sig-apps 8c23329eef8d21349bb7be9cde967e6982015f64 link true /test e2e-openshift-conformance-sig-apps

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pmtk pmtk force-pushed the rebase/recipe-simple-presubmit branch 4 times, most recently from 419367e to 2993774 Compare February 14, 2023 08:34
@pmtk pmtk force-pushed the rebase/recipe-simple-presubmit branch from 2993774 to 52e01cc Compare February 14, 2023 16:11
build two sets:
- files present in assets/
- files referenced in assets.yaml

Sets are diffed against each other to get:
- files not referenced in assets.yml but present in assets/ (missing)
- files referenced in assets.yml but missing from assets/ (superfluous)
@pmtk pmtk force-pushed the rebase/recipe-simple-presubmit branch from 52e01cc to f758e50 Compare February 15, 2023 07:44
@pmtk
Copy link
Member Author

pmtk commented Feb 15, 2023

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 15, 2023
@ggiguash
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 9518cbb into openshift:main Feb 15, 2023
@pmtk pmtk deleted the rebase/recipe-simple-presubmit branch March 29, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants