OCPBUGS-7205: don't advertise ovn-kubernetes local addresses in mdns

[zshi-redhat]

Signed-off-by: Zenghui Shi zshi@redhat.com

[openshift-ci-robot]

@zshi-redhat: This pull request references Jira Issue OCPBUGS-7205, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.13.0) matches configured target version for branch (4.13.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jogeo

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Signed-off-by: Zenghui Shi zshi@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dhellmann]

This introduces a dependency between the MDNS and OVN components, which is going to make it harder to make OVN pluggable. We can do this for now, but we need a plan to decouple these again in the future. What can we do to keep them loosely coupled?

[zshi-redhat]

I'm actually doing some code preparation work in this PR to move ovnk related code in its own files under pkg/config/ovn. Before this PR, the ovnk interfaces and special IP address are hardcoded in mdns controller. For fully decoupling ovnk from mdns controller (assuming mdns will stay in microshift main), we would need an interface between microshift and plugins to exchange the mdns related information (this is where the binary/script method in pluggable enhancement would help).

[dhellmann]

Let's move ahead with this fix. We will have to think about the MDNS requirements when we split CNI out of the MicroShift binary.

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, zshi-redhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [dhellmann,zshi-redhat]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 6458f33 and 2 for PR HEAD 4dd7e08 in total

[openshift-ci]

@zshi-redhat: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-rpm-install	4dd7e08	link	unknown	/test e2e-rpm-install

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@zshi-redhat: All pull requests linked via external trackers have merged:

• openshift/microshift#1348

Jira Issue OCPBUGS-7205 has been moved to the MODIFIED state.

Details

In response to this:

Signed-off-by: Zenghui Shi zshi@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.