Skip to content

OCPBUGS-6858: Add minimum CRIO version as rpm requirement#1328

Merged
openshift-merge-robot merged 1 commit intoopenshift:mainfrom
oglok:criodep
Feb 7, 2023
Merged

OCPBUGS-6858: Add minimum CRIO version as rpm requirement#1328
openshift-merge-robot merged 1 commit intoopenshift:mainfrom
oglok:criodep

Conversation

@oglok
Copy link
Contributor

@oglok oglok commented Feb 6, 2023

Signed-off-by: Ricardo Noriega rnoriega@redhat.com

Which issue(s) this PR addresses:

Closes OCPBUGS-6858

Signed-off-by: Ricardo Noriega <rnoriega@redhat.com>
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 6, 2023
@openshift-ci-robot
Copy link

@oglok: This pull request references Jira Issue OCPBUGS-6858, which is invalid:

  • expected the bug to target the "4.13.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Signed-off-by: Ricardo Noriega rnoriega@redhat.com

Which issue(s) this PR addresses:

Closes OCPBUGS-6858

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from pacevedom and pmtk February 6, 2023 15:49
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2023
@ggiguash
Copy link
Contributor

ggiguash commented Feb 6, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, oglok

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ggiguash
Copy link
Contributor

ggiguash commented Feb 6, 2023

/jira refresh

@openshift-ci-robot
Copy link

@ggiguash: An error was encountered querying GitHub for users with public email (jgeorge@redhat.com) for bug OCPBUGS-6858 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details.

Full error message. Post "http://ghproxy/graphql": dial tcp 172.30.229.2:80: connect: connection refused

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ggiguash
Copy link
Contributor

ggiguash commented Feb 6, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 6, 2023
@openshift-ci-robot
Copy link

@ggiguash: This pull request references Jira Issue OCPBUGS-6858, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jogeo

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from jogeo February 6, 2023 16:47
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 0f65966 and 2 for PR HEAD b017cb4 in total

@ggiguash
Copy link
Contributor

ggiguash commented Feb 7, 2023

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD c63ec51 and 1 for PR HEAD b017cb4 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 7, 2023

@oglok: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit b054278 into openshift:main Feb 7, 2023
@openshift-ci-robot
Copy link

@oglok: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-6858 has not been moved to the MODIFIED state.

Details

In response to this:

Signed-off-by: Ricardo Noriega rnoriega@redhat.com

Which issue(s) this PR addresses:

Closes OCPBUGS-6858

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@oglok
Copy link
Contributor Author

oglok commented Feb 7, 2023

/cherrypick release-4.12

@openshift-cherrypick-robot

@oglok: #1328 failed to apply on top of branch "release-4.12":

Applying: Add minimum CRIO version as rpm requirement
Using index info to reconstruct a base tree...
M	packaging/rpm/microshift.spec
Falling back to patching base and 3-way merge...
Auto-merging packaging/rpm/microshift.spec
CONFLICT (content): Merge conflict in packaging/rpm/microshift.spec
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Add minimum CRIO version as rpm requirement
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherrypick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants