Skip to content

OCPBUGS-7084: hostnameOverride config missing in kubelet#1326

Merged
openshift-merge-robot merged 1 commit intoopenshift:mainfrom
pacevedom:OCPBUGS-7084
Feb 7, 2023
Merged

OCPBUGS-7084: hostnameOverride config missing in kubelet#1326
openshift-merge-robot merged 1 commit intoopenshift:mainfrom
pacevedom:OCPBUGS-7084

Conversation

@pacevedom
Copy link
Contributor

Ever since the hostname change detection was introduced (715612e) this situation is detected and avoided. There was a missing flag in the kubelet preventing the Ready state of the node, as it was trying to use the new name instead of the established one.

Which issue(s) this PR addresses:

Closes #

Ever since the hostname change detection was introduced (715612e) this
situation is detected and avoided. There was a missing flag in the
kubelet preventing the Ready state of the node, as it was trying to use
the new name instead of the established one.
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Feb 6, 2023
@openshift-ci-robot
Copy link

@pacevedom: This pull request references Jira Issue OCPBUGS-7084, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jogeo

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Ever since the hostname change detection was introduced (715612e) this situation is detected and avoided. There was a missing flag in the kubelet preventing the Ready state of the node, as it was trying to use the new name instead of the established one.

Which issue(s) this PR addresses:

Closes #

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from jogeo February 6, 2023 14:50
@pacevedom
Copy link
Contributor Author

/cc @zshi-redhat @mangelajo @pmtk

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2023
@pacevedom
Copy link
Contributor Author

/retest

@zshi-redhat
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pacevedom, zshi-redhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [pacevedom,zshi-redhat]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 0f65966 and 2 for PR HEAD 236ef6f in total

@pacevedom
Copy link
Contributor Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 7, 2023

@pacevedom: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 4e369ee into openshift:main Feb 7, 2023
@openshift-ci-robot
Copy link

@pacevedom: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-7084 has been moved to the MODIFIED state.

Details

In response to this:

Ever since the hostname change detection was introduced (715612e) this situation is detected and avoided. There was a missing flag in the kubelet preventing the Ready state of the node, as it was trying to use the new name instead of the established one.

Which issue(s) this PR addresses:

Closes #

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants