Skip to content

OCPBUGS-7056: fix ovn config file path#1322

Merged
openshift-merge-robot merged 1 commit intoopenshift:mainfrom
zshi-redhat:fix-ovnk-config-path
Feb 6, 2023
Merged

OCPBUGS-7056: fix ovn config file path#1322
openshift-merge-robot merged 1 commit intoopenshift:mainfrom
zshi-redhat:fix-ovnk-config-path

Conversation

@zshi-redhat
Copy link
Contributor

GetConfigFile() may return empty path or user defined path, but ovn config file is only supported under /etc/microshift

Signed-off-by: Zenghui Shi zshi@redhat.com

GetConfigFile() may return empty path or user defined path,
but ovn config file is only supported under /etc/microshift

Signed-off-by: Zenghui Shi <zshi@redhat.com>
@openshift-ci openshift-ci bot requested review from benluddy and stlaz February 5, 2023 13:09
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2023
@ggiguash
Copy link
Contributor

ggiguash commented Feb 5, 2023

@zshi-redhat, can we link this PR to a JIRA issue/bug?

@zshi-redhat zshi-redhat changed the title Fix ovn config file path OCPBUGS-7056: fix ovn config file path Feb 6, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 6, 2023
@openshift-ci-robot
Copy link

@zshi-redhat: This pull request references Jira Issue OCPBUGS-7056, which is invalid:

  • expected the bug to target the "4.13.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

GetConfigFile() may return empty path or user defined path, but ovn config file is only supported under /etc/microshift

Signed-off-by: Zenghui Shi zshi@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Feb 6, 2023
@zshi-redhat
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

@zshi-redhat: This pull request references Jira Issue OCPBUGS-7056, which is invalid:

  • expected the bug to target the "4.13.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zshi-redhat
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 6, 2023
@openshift-ci-robot
Copy link

@zshi-redhat: This pull request references Jira Issue OCPBUGS-7056, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jogeo

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from jogeo February 6, 2023 01:14
@zshi-redhat
Copy link
Contributor Author

@zshi-redhat, can we link this PR to a JIRA issue/bug?

Done.

@ggiguash
Copy link
Contributor

ggiguash commented Feb 6, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, zshi-redhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [ggiguash,zshi-redhat]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zshi-redhat
Copy link
Contributor Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 6, 2023

@zshi-redhat: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit dd59dc4 into openshift:main Feb 6, 2023
@openshift-ci-robot
Copy link

@zshi-redhat: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-7056 has been moved to the MODIFIED state.

Details

In response to this:

GetConfigFile() may return empty path or user defined path, but ovn config file is only supported under /etc/microshift

Signed-off-by: Zenghui Shi zshi@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zshi-redhat
Copy link
Contributor Author

/cherrypick release-4.12

@openshift-cherrypick-robot

@zshi-redhat: new pull request created: #1335

Details

In response to this:

/cherrypick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants