Skip to content

4.12: Avoid firewalld flush of iptables#1306

Closed
mangelajo wants to merge 1 commit intoopenshift:release-4.12from
mangelajo:release-4.12
Closed

4.12: Avoid firewalld flush of iptables#1306
mangelajo wants to merge 1 commit intoopenshift:release-4.12from
mangelajo:release-4.12

Conversation

@mangelajo
Copy link
Contributor

@mangelajo mangelajo commented Jan 31, 2023 •
edited
Loading

cherry pick from #1300 (automatic cherry
pick failed with conflict on the microshift.spec file changelog entries)

  • Avoid firewalld flush of iptables

https://issues.redhat.com/browse/NP-641
https://issues.redhat.com/browse/USHIFT-789

@mangelajo
Avoid firewalld flush of iptables
bef7b36 
Disables firewalld access to iptables related nftables translator,
this avoids firewalld flush of iptables under any circumstance,
firewalld will work at nftables level, while MicroShift/OVN can
continue to work at iptables level (translated to nft) under the hood.

(cherry picked from commit f51d031)
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 31, 2023
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Jan 31, 2023

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mangelajo mangelajo changed the base branch from main to release-4.12 January 31, 2023 11:00
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 31, 2023

@mangelajo: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

release 4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 31, 2023

@mangelajo: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

release 4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from pacevedom and stlaz January 31, 2023 11:02
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 31, 2023

@mangelajo: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

release 4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mangelajo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2023
@ggiguash
Copy link
Contributor

ggiguash commented Jan 31, 2023

/retitle 4.12: Avoid firewalld flush of iptables

@openshift-ci openshift-ci bot changed the title release 4.12 4.12: Avoid firewalld flush of iptables Jan 31, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 31, 2023

@mangelajo: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

4.12: Avoid firewalld flush of iptables

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

3 similar comments
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 31, 2023

@mangelajo: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

4.12: Avoid firewalld flush of iptables

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 31, 2023

@mangelajo: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

4.12: Avoid firewalld flush of iptables

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 31, 2023

@mangelajo: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

4.12: Avoid firewalld flush of iptables

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mangelajo
Copy link
Contributor Author

mangelajo commented Jan 31, 2023 •
edited by openshift-ci bot
Loading

Bug USHIFT-789

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 31, 2023

@mangelajo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openshift-conformance-sig-auth bef7b36 link true /test e2e-openshift-conformance-sig-auth
ci/prow/e2e-openshift-conformance-sig-apps bef7b36 link true /test e2e-openshift-conformance-sig-apps
ci/prow/periodics-images bef7b36 link true /test periodics-images
ci/prow/periodics-images bef7b36 link true /test periodics-images
ci/prow/verify bef7b36 link true /test verify
ci/prow/e2e-openshift-conformance-sig-instrumentation bef7b36 link true /test e2e-openshift-conformance-sig-instrumentation
ci/prow/periodic-ocp-4.12-images bef7b36 link true /test periodic-ocp-4.12-images
ci/prow/e2e-router-smoke-test bef7b36 link false /test e2e-router-smoke-test
ci/prow/e2e-rpm-install bef7b36 link true /test e2e-rpm-install
ci/prow/test-unit bef7b36 link true /test test-unit
ci/prow/e2e-openshift-conformance-sig-node bef7b36 link true /test e2e-openshift-conformance-sig-node
ci/prow/e2e-reboot bef7b36 link true /test e2e-reboot
ci/prow/e2e-openshift-conformance-sig-storage bef7b36 link true /test e2e-openshift-conformance-sig-storage
ci/prow/images bef7b36 link true /test images
ci/prow/test-srpm bef7b36 link true /test test-srpm
ci/prow/e2e-openshift-conformance-sig-scheduling bef7b36 link true /test e2e-openshift-conformance-sig-scheduling
ci/prow/e2e-openshift-conformance-sig-cli bef7b36 link true /test e2e-openshift-conformance-sig-cli
ci/prow/e2e-openshift-conformance-sig-api-machinery bef7b36 link true /test e2e-openshift-conformance-sig-api-machinery
ci/prow/e2e-openshift-conformance-sig-arch bef7b36 link true /test e2e-openshift-conformance-sig-arch
ci/prow/e2e-openshift-conformance-sig-network bef7b36 link true /test e2e-openshift-conformance-sig-network

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mangelajo mangelajo removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 31, 2023
@mangelajo mangelajo requested review from ggiguash and pmtk January 31, 2023 14:16
@mangelajo mangelajo closed this Jan 31, 2023
@dhellmann dhellmann mentioned this pull request Jan 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pacevedom pacevedom Awaiting requested review from pacevedom

@stlaz stlaz Awaiting requested review from stlaz

@pmtk pmtk Awaiting requested review from pmtk

@ggiguash ggiguash Awaiting requested review from ggiguash

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mangelajo @openshift-merge-robot @ggiguash