Skip to content

rebase 1185#1296

Closed
mangelajo wants to merge 2 commits intomainfrom
rebase-1185
Closed

rebase 1185#1296
mangelajo wants to merge 2 commits intomainfrom
rebase-1185

Conversation

@mangelajo
Copy link
Contributor

@mangelajo mangelajo commented Jan 26, 2023

This is a rebase of #1185 with a branch on the openshift/microshift repo to allow @jogeo to test on CI.

  • Watch firewall reload in sysconfigwatcher
  • Move firewall watch logic to infrastructure manager

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mangelajo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 26, 2023

@mangelajo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-reboot 84df62c link true /test e2e-reboot
ci/prow/e2e-openshift-conformance-sig-node 84df62c link true /test e2e-openshift-conformance-sig-node
ci/prow/e2e-openshift-conformance-sig-instrumentation 84df62c link true /test e2e-openshift-conformance-sig-instrumentation
ci/prow/e2e-router-smoke-test 84df62c link false /test e2e-router-smoke-test
ci/prow/e2e-openshift-conformance-sig-storage 84df62c link true /test e2e-openshift-conformance-sig-storage
ci/prow/e2e-openshift-conformance-sig-auth 84df62c link true /test e2e-openshift-conformance-sig-auth
ci/prow/e2e-openshift-conformance-sig-arch 84df62c link true /test e2e-openshift-conformance-sig-arch
ci/prow/e2e-openshift-conformance-sig-apps 84df62c link true /test e2e-openshift-conformance-sig-apps
ci/prow/e2e-openshift-conformance-sig-cli 84df62c link true /test e2e-openshift-conformance-sig-cli
ci/prow/e2e-rpm-install 84df62c link true /test e2e-rpm-install
ci/prow/e2e-openshift-conformance-sig-network 84df62c link true /test e2e-openshift-conformance-sig-network
ci/prow/e2e-openshift-conformance-sig-api-machinery 84df62c link true /test e2e-openshift-conformance-sig-api-machinery

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mangelajo
Copy link
Contributor Author

We have noticed that sometimes ovnkube-master fails to become ready after this restart.

@mangelajo
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 27, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 31, 2023
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mangelajo mangelajo closed this Jan 31, 2023
@microshift-rebase-script microshift-rebase-script bot deleted the rebase-1185 branch December 15, 2023 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants