Skip to content

rebase.sh: remove previous last_rebase.sh#1208

Merged
openshift-merge-robot merged 2 commits intoopenshift:mainfrom
pmtk:last-rebase-workaround
Dec 21, 2022
Merged

rebase.sh: remove previous last_rebase.sh#1208
openshift-merge-robot merged 2 commits intoopenshift:mainfrom
pmtk:last-rebase-workaround

Conversation

@pmtk
Copy link
Member

@pmtk pmtk commented Dec 21, 2022

CI jobs script run as nonroot, but repo is cloned as root.
Job can change files' contents freely or even delete files, but it's unable to change permissions of files it doesn't own:

chmod: changing permissions of '(...)/last_rebase.sh': Operation not permitted

CI jobs are ran as random user, but repo is cloned as root. Job can change files' contents freely or even delete files but it's unable to change permissions of files it doesn't own:
chmod: changing permissions of '(...)/last_rebase.sh': Operation not permitted
@openshift-ci openshift-ci bot requested review from fzdarsky and ggiguash December 21, 2022 15:35
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 21, 2022
Co-authored-by: Gregory Giguashvili <85498834+ggiguash@users.noreply.github.com>
@pmtk
Copy link
Member Author

pmtk commented Dec 21, 2022

/label tide/merge-method-squash

@openshift-ci openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Dec 21, 2022
@ggiguash
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 21, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ggiguash
Copy link
Contributor

/override ci/prow/e2e-openshift-conformance-sig-api-machinery
/override ci/prow/e2e-router-smoke-test
/override ci/prow/e2e-rpm-install

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 21, 2022

@ggiguash: Overrode contexts on behalf of ggiguash: ci/prow/e2e-openshift-conformance-sig-api-machinery, ci/prow/e2e-router-smoke-test, ci/prow/e2e-rpm-install

Details

In response to this:

/override ci/prow/e2e-openshift-conformance-sig-api-machinery
/override ci/prow/e2e-router-smoke-test
/override ci/prow/e2e-rpm-install

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 21, 2022

@pmtk: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants