Skip to content

NOISSUE: save last image references so it is easy to reproduce the rebase#1197

Merged
openshift-merge-robot merged 1 commit intoopenshift:mainfrom
dhellmann:rebase-record-pull-specs
Dec 16, 2022
Merged

NOISSUE: save last image references so it is easy to reproduce the rebase#1197
openshift-merge-robot merged 1 commit intoopenshift:mainfrom
dhellmann:rebase-record-pull-specs

Conversation

@dhellmann
Copy link
Contributor

This change adds a step to the rebase.sh to command to record the
image references used in the rebase. They are saved in the form of
a script that can be used to run the same rebase command again,
which makes it easy to test changes to the rebase script.

/assign @pmtk @fzdarsky

Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
@openshift-ci openshift-ci bot requested review from oglok and zshi-redhat December 15, 2022 21:57
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2022
@dhellmann
Copy link
Contributor Author

When I ran this version of rebase.sh locally, it produced:


commit 6d69c82c29f308990dc6290f5280cfa97875eb44
Author: Doug Hellmann <dhellmann@redhat.com>
Date:   Thu Dec 15 16:52:27 2022 -0500

    update last_rebase.sh

diff --git a/scripts/auto-rebase/last_rebase.sh b/scripts/auto-rebase/last_rebase.sh
new file mode 100755
index 000000000..38049b88a
--- /dev/null
+++ b/scripts/auto-rebase/last_rebase.sh
@@ -0,0 +1,2 @@
+#!/bin/bash -x
+./scripts/auto-rebase/rebase.sh to "registry.ci.openshift.org/ocp/release:4.12.0-0.nightly-2022-12-14-135139" "registry.ci.openshift.org/ocp-arm64/release-arm64:4.12.0-0.nightly-arm64-2022-12-14-185905"

@mangelajo
Copy link
Contributor

/approve

@pmtk
Copy link
Member

pmtk commented Dec 16, 2022

This is nice, looks like this could be useful when we add job verifying if rebase script was not broken
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, mangelajo, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [dhellmann,mangelajo,pmtk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD c3f07cb and 2 for PR HEAD 736d32c in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 16, 2022

@dhellmann: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants