USHIFT-677: Remove _output on successful rebase#1191
USHIFT-677: Remove _output on successful rebase#1191openshift-merge-robot merged 1 commit intoopenshift:mainfrom
Conversation
openshift-ci
bot
added
the
approved
|
@pmtk: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| fi | ||
|
|
||
| title "# Removing staging directory" | ||
| rm -rf "$REPOROOT/_output" |
There was a problem hiding this comment.
Does this mean the directory is only cleaned up in the full "to" workflow? But if a developer uses the individual commands to fetch images, update manifests, etc. then the temporary directory is not cleaned up? I think that's what we want, but I want to make sure I understand the changes.
There was a problem hiding this comment.
Exactly. And if anything along the way fails, script won't reach the removal, so (I hope) this addition won't be an annoyance for devs, but will address source RPM issue on our side rather than ART's.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhellmann, pmtk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
No description provided.