Add rhel volume group creation to dev env docs#1189
Add rhel volume group creation to dev env docs#1189openshift-merge-robot merged 1 commit intoopenshift:mainfrom
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
approved
docs/devenv_rhel8.md
Outdated
There was a problem hiding this comment.
The default VG to be created is already rhel. Did you mean to verify it's set to rhel or actually to create a new one?
There was a problem hiding this comment.
Had a vg called microshift_root00 in my case. Maybe wording this to verify/ensure is better.
There was a problem hiding this comment.
Yes, this needs to be fixed. There's no need to create a new volume. We just need to make sure that the root volume is called rhel and it has unallocated space.
docs/devenv_rhel8.md
Outdated
There was a problem hiding this comment.
Yes, this needs to be fixed. There's no need to create a new volume. We just need to make sure that the root volume is called rhel and it has unallocated space.
pacevedom
force-pushed
the
vg-dev-env
branch
from
8975b88 to
e4fb2c0
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ggiguash, pacevedom The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@pacevedom: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
4 participants
Which issue(s) this PR addresses:
Closes #
/cc @ggiguash