Skip to content

USHIFT-674: Fix show-config command#1188

Merged
openshift-merge-robot merged 1 commit intoopenshift:mainfrom
fzdarsky:fix-show-config
Dec 12, 2022
Merged

USHIFT-674: Fix show-config command#1188
openshift-merge-robot merged 1 commit intoopenshift:mainfrom
fzdarsky:fix-show-config

Conversation

@fzdarsky
Copy link
Contributor

@fzdarsky fzdarsky commented Dec 11, 2022

Fixes show-config to show user configuration again, instead of internal representation.

Signed-off-by: Frank A. Zdarsky fzdarsky@redhat.com

Closes USHIFT-674

Signed-off-by: Frank A. Zdarsky <fzdarsky@redhat.com>
@openshift-ci openshift-ci bot requested review from dhellmann and stlaz December 11, 2022 19:34
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2022
@fzdarsky fzdarsky requested review from mangelajo and oglok and removed request for stlaz December 12, 2022 09:09
@dhellmann
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 12, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, fzdarsky

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 94fe11b and 2 for PR HEAD 5ffa104 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 12, 2022

@fzdarsky: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants