ETCD-356: Changing etcd data directory to /var/lib/etcd

[dusk125]

This change aligns the etcd data directory with that of OpenShift so that existing scripts, documentation, and customer/support knowledge can be more easily applied to MicroShift for etcd.

[dusk125]

/hold
Waiting for 4.12 to branch so this can land in early 4.13

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dusk125
Once this PR has been reviewed and has the lgtm label, please assign dhellmann for approval by writing /assign @dhellmann in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@dusk125: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-openshift-conformance-sig-auth	02f9732467432fe11038ee5f7fe28d54b4248b00	link	true	/test e2e-openshift-conformance-sig-auth

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[mangelajo]

Doing it in 4.13 could potentially need a migration path?, for example customers upgrading from 4.12 to 4.13?, I propose we do it for 4.12 if possible. But I know we are already trying to squeeze too much for release. @ggiguash @dhellmann

[dhellmann]

Doing it in 4.13 could potentially need a migration path?, for example customers upgrading from 4.12 to 4.13?, I propose we do it for 4.12 if possible. But I know we are already trying to squeeze too much for release. @ggiguash @dhellmann

We do not have a requirement to be able to upgrade from 4.12 to 4.13, so it should be safe to do this work in 4.13.

[dusk125]

This is planned to land after #976 the hold is still valid until that merges

[dusk125]

This is ready for consideration @dhellmann @pmtk
/unhold

[dhellmann]

I'm a little torn on this. On the one hand, I see the value of being consistent. On the other hand, we don't want to support etcd running on its own, outside of MicroShift, and this move makes that product decision a little fuzzier.

If we do want to do this, the PR needs to update hack/cleanup.sh as well.

[ggiguash]

I agree with @dhellmann 's comment. I'm not sure we'd want to handle etcd database out of MicroShift context.

[dhellmann]

/assign @dhellmann

[dhellmann]

/assign @pmtk

[ggiguash]

If we implement this change, the cleanup script also needs to be updated to delete the directory out of /var/lib/microshift

[ggiguash]

/hold
Pending a discussion and decision whether to proceed with this change

[dusk125]

More discussion is needed around this and other alignment of etcd