Re-introduce PR#1030 baseDomain patch and add backend logic#1176
Re-introduce PR#1030 baseDomain patch and add backend logic#1176openshift-merge-robot merged 5 commits intoopenshift:mainfrom
Conversation
Co-authored-by: Vu Dinh <vudinh@outlook.com> Co-authored-by: Damien Grisonnet <dgrisonn@redhat.com>
|
@fzdarsky @dinhxuanvu , please see the two commit structure, on first commit, I introduce @dinhxuanvu original patch, on second commit I handle the logic to match OpenShift behavior, also introducing the fixed "cluster.local" setting. |
mangelajo
changed the title
openshift-ci
bot
added
the
approved
ClusterDomain is removed in the previous commit, since OpenShift seems to always hardcode "cluster.local" in the DNS operator. BaseDomain is propagated down to the right places, like TLS certificate generation, and injected into the router pod.
| // For example, given the base domain `openshift.example.com`, an API server | ||
| // DNS record may be created for `cluster-api.openshift.example.com`. | ||
| // | ||
| // Once set, this field cannot be changed. |
There was a problem hiding this comment.
Do we need another ticket to protect against the value changing?
There was a problem hiding this comment.
I believe that this is a comment inherited from the OCP config API: https://github.com/openshift/api/blob/master/config/v1/types_dns.go#L27-L34
We might want to update it if it doesn't apply to MicroShift
There was a problem hiding this comment.
It does apply to MicroShift, too, I think @dhellmann 's concern was more where/how this is enforced.
There was a problem hiding this comment.
We may want to enforce against changes, I agree.
dinhxuanvu
left a comment
dinhxuanvu
left a comment
There was a problem hiding this comment.
Just a few minor nits. Overall, the PR looks good.
|
Squash at least last two commits, so we avoid having two with the same title in history. |
|
/lgtm |
mangelajo
added
the
tide/merge-method-squash
I added the merge method "squash" for tide to handle. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fzdarsky, mangelajo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
@mangelajo: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
8 participants
Uh oh!
There was an error while loading. Please reload this page.