Skip to content

USHIFT-660: yet another cluster debug info improvement#1175

Merged
openshift-merge-robot merged 1 commit intoopenshift:mainfrom
pmtk:debug-logs-table-of-contents
Dec 7, 2022
Merged

USHIFT-660: yet another cluster debug info improvement#1175
openshift-merge-robot merged 1 commit intoopenshift:mainfrom
pmtk:debug-logs-table-of-contents

Conversation

@pmtk
Copy link
Member

@pmtk pmtk commented Dec 7, 2022

changed execution flow to:

  • first register commands to run
  • print a "table of contents" so it's obvious what command will be executed and easily searched for
  • print a command with > prefix and execute the command

By replacing set -x with printing the cmd it is now visually clearer and suitable for inclusion in bug tickets (./validate-microshift/cluster-debug-info.sh > /tmp/cluster.log)

@openshift-ci openshift-ci bot requested review from ggiguash and stlaz December 7, 2022 10:24
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2022
@pmtk pmtk force-pushed the debug-logs-table-of-contents branch from b50d62c to 6e1bc95 Compare December 7, 2022 10:28
@ggiguash
Copy link
Contributor

ggiguash commented Dec 7, 2022

/retitle USHIFT-660: yet another cluster debug info improvement

/lgtm

@openshift-ci openshift-ci bot changed the title yet another cluster debug info improvement USHIFT-660: yet another cluster debug info improvement Dec 7, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 7, 2022

@pmtk: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-router-smoke-test 6e1bc95 link false /test e2e-router-smoke-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants