operator/ingress: Add httpLogFormat validation#2794
operator/ingress: Add httpLogFormat validation#2794Miciah wants to merge 1 commit intoopenshift:masterfrom
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
Skipping CI for Draft Pull Request. |
|
Hello @Miciah! Some important instructions when contributing to openshift/api: |
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/test integration |
|
PR-Agent: could not fine a component named |
01df9de to
1b217aa
Compare
|
/test integration |
|
PR-Agent: could not fine a component named |
* operator/v1/tests/ingresscontrollers.operator.openshift.io/AAA_ungated.yaml: Add some integration tests for IngressController.spec.logging.access.httpLogFormat. * operator/v1/types_ingress.go (AccessLogging): Add a kubebuilder validation pattern to the httpLogFormat field. * operator/v1/zz_generated.crd-manifests/*: * operator/v1/zz_generated.featuregated-crd-manifests/ingresscontrollers.operator.openshift.io/AAA_ungated.yaml: * operator/v1/zz_generated.featuregated-crd-manifests/ingresscontrollers.operator.openshift.io/IngressControllerDynamicConfigurationManager.yaml: Regenerate.
1b217aa to
92a3c14
Compare
|
/test integration |
|
PR-Agent: could not fine a component named |
|
@Miciah: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Add a kubebuilder validation pattern and integration tests for the
IngressController.spec.logging.access.httpLogFormatAPI field.