Skip to content

operator/ingress: Add httpLogFormat validation#2794

Draft
Miciah wants to merge 1 commit intoopenshift:masterfrom
Miciah:operator-slash-ingress-add-httpLogFormat-validation
Draft

operator/ingress: Add httpLogFormat validation#2794
Miciah wants to merge 1 commit intoopenshift:masterfrom
Miciah:operator-slash-ingress-add-httpLogFormat-validation

Conversation

@Miciah
Copy link
Copy Markdown
Contributor

@Miciah Miciah commented Apr 2, 2026

Add a kubebuilder validation pattern and integration tests for the IngressController.spec.logging.access.httpLogFormat API field.

@openshift-ci-robot
Copy link
Copy Markdown

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 2, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 2, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 2, 2026

Hello @Miciah! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 2, 2026

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 50176e3b-08ff-40e9-862a-37c4993296d0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 2, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 2, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Miciah
Copy link
Copy Markdown
Contributor Author

Miciah commented Apr 2, 2026

/test integration
/test lint
/test unit
/test verify

@qodo-code-review
Copy link
Copy Markdown

qodo-code-review bot commented Apr 2, 2026

PR-Agent: could not fine a component named integration in a supported language in this PR.

@Miciah Miciah force-pushed the operator-slash-ingress-add-httpLogFormat-validation branch from 01df9de to 1b217aa Compare April 2, 2026 22:47
@Miciah
Copy link
Copy Markdown
Contributor Author

Miciah commented Apr 2, 2026

/test integration

@openshift-ci openshift-ci bot removed the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 2, 2026
@qodo-code-review
Copy link
Copy Markdown

qodo-code-review bot commented Apr 2, 2026

PR-Agent: could not fine a component named integration in a supported language in this PR.

@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 2, 2026
* operator/v1/tests/ingresscontrollers.operator.openshift.io/AAA_ungated.yaml:
Add some integration tests for
IngressController.spec.logging.access.httpLogFormat.
* operator/v1/types_ingress.go (AccessLogging): Add a kubebuilder
validation pattern to the httpLogFormat field.
* operator/v1/zz_generated.crd-manifests/*:
* operator/v1/zz_generated.featuregated-crd-manifests/ingresscontrollers.operator.openshift.io/AAA_ungated.yaml:
* operator/v1/zz_generated.featuregated-crd-manifests/ingresscontrollers.operator.openshift.io/IngressControllerDynamicConfigurationManager.yaml:
Regenerate.
@Miciah Miciah force-pushed the operator-slash-ingress-add-httpLogFormat-validation branch from 1b217aa to 92a3c14 Compare April 2, 2026 23:52
@Miciah
Copy link
Copy Markdown
Contributor Author

Miciah commented Apr 2, 2026

/test integration
/test verify

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 2, 2026
@qodo-code-review
Copy link
Copy Markdown

qodo-code-review bot commented Apr 2, 2026

PR-Agent: could not fine a component named integration in a supported language in this PR.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 3, 2026

@Miciah: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/integration 92a3c14 link true /test integration

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants