Skip to content

NE-2569: Promote Dynamic Configuration Manager to Default#2788

Draft
Miciah wants to merge 1 commit intoopenshift:masterfrom
Miciah:NE-2569-promote-Dynamic-Configuration-Manager-to-Default
Draft

NE-2569: Promote Dynamic Configuration Manager to Default#2788
Miciah wants to merge 1 commit intoopenshift:masterfrom
Miciah:NE-2569-promote-Dynamic-Configuration-Manager-to-Default

Conversation

@Miciah
Copy link
Copy Markdown
Contributor

@Miciah Miciah commented Mar 31, 2026

Promote the IngressControllerDynamicConfigurationManager featuregate to the Default featureset.

This PR depends on openshift/origin#30926.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 31, 2026

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 31, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 31, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 31, 2026

Hello @Miciah! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 31, 2026 •
edited
Loading

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 89e0234e-18d2-4e56-aac1-bfb4be07fbef

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 31, 2026
@Miciah
Promote Dynamic Configuration Manager to Default
52fb33c 
Promote the IngressControllerDynamicConfigurationManager featuregate to
the Default featureset.

This commit resolves NE-2569.

https://redhat.atlassian.net/browse/NE-2569

* features/features.go: Promote the featuregate to Default.
* features.md:
* operator/v1/zz_generated.crd-manifests/*:
* payload-manifests/featuregates/*: Regenerate.
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 31, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Miciah Miciah force-pushed the NE-2569-promote-Dynamic-Configuration-Manager-to-Default branch from cd8658e to 52fb33c Compare March 31, 2026 21:06
@Miciah Miciah changed the title Promote Dynamic Configuration Manager to Default NE-2569: Promote Dynamic Configuration Manager to Default Mar 31, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 31, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 31, 2026 •
edited by openshift-ci bot
Loading

@Miciah: This pull request references NE-2569 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Promote the IngressControllerDynamicConfigurationManager featuregate to the Default featureset.

This PR depends on openshift/origin#30926.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Miciah
Copy link
Copy Markdown
Contributor Author

Miciah commented Mar 31, 2026

/jira refresh

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 31, 2026 •
edited by openshift-ci bot
Loading

@Miciah: This pull request references NE-2569 which is a valid jira issue.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Miciah
Copy link
Copy Markdown
Contributor Author

Miciah commented Apr 1, 2026

/test lint
/test integration
/test verify
/test verify-client-go
/test verify-crd-schema
/test verify-crdify
/test verify-deps
/test verify-feature-promotion

@qodo-code-review
Copy link
Copy Markdown

qodo-code-review bot commented Apr 1, 2026 •
edited
Loading

PR-Agent: could not fine a component named lint in a supported language in this PR.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 1, 2026

@Miciah: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify 52fb33c link true /test verify
ci/prow/verify-feature-promotion 52fb33c link true /test verify-feature-promotion

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jcmoraisjr
Copy link
Copy Markdown
Member

jcmoraisjr commented Apr 1, 2026

/assign

@bentito
Copy link
Copy Markdown
Contributor

bentito commented Apr 1, 2026

/assign @jcmoraisjr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jcmoraisjr jcmoraisjr

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Miciah @openshift-ci-robot @jcmoraisjr @bentito