Konflux configurations architecture diagram#380
Konflux configurations architecture diagram#380pierDipi wants to merge 2 commits intoopenshift-knative:mainfrom
Conversation
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
creydr
left a comment
There was a problem hiding this comment.
Nice!
Where did you create those images? Is there a way, we could also add the "raw" file to this PR, so we could update the image later too?
|
Raw parts are backed into the image, you can just import it and work on it, excalidraw is the tool |
|
Nice :) But 7.5 MB per Image in Git 🤷 ? Maybe cause of #380 (comment)? Or are there other things in it? |
No, there is only the image PNG + metadata to recreate the original design, what's the issue with that? |
|
|
||
| # Konflux | ||
|
|
||
| The architecture of the Konflux configuration architecture is summarized in this diagram: |
There was a problem hiding this comment.
Could you add some more info about design decisions made, so we may iterate on in the future? For example explain a bit the diagrams and any assumptions.
There was a problem hiding this comment.
I can add more details soon
Seems oddly large for such a small image (draw.io) does the same and is in KB not MB. Especially if changed the git repo size grows for each revision - but anyway. |
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Click on
view filein the top-right corner of the README.md review tag to view the diagrams