Skip to content

Comments

Add incremental plan and benchmark helper for join key pre-filtering RFC#5151

Draft
nicepopo86-lang wants to merge 1 commit intoopensearch-project:mainfrom
nicepopo86-lang:aria/issue-5093-uniontype-small-improvement
Draft

Add incremental plan and benchmark helper for join key pre-filtering RFC#5151
nicepopo86-lang wants to merge 1 commit intoopensearch-project:mainfrom
nicepopo86-lang:aria/issue-5093-uniontype-small-improvement

Conversation

@nicepopo86-lang
Copy link

Summary

This PR adds a concrete incremental implementation aid for RFC #5093:

  1. docs/dev/join-key-prefiltering-rfc-notes.md
    • narrows the optimization into safe rollout phases
    • defines guardrails, config knobs, and validation matrix
  2. docs/dev/queries/join-key-prefiltering.ppl
    • reusable query fixture for this join shape
  3. scripts/benchmark_join_prefilter.sh
    • lightweight benchmark helper for /_plugins/_ppl
    • supports hyperfine when available, curl fallback otherwise

Why this helps

The issue is an RFC/performance optimization topic; this PR converts it into a reviewable and testable next step without introducing risky planner changes in one shot.

Validation

  • bash -n scripts/benchmark_join_prefilter.sh
  • script is executable and documented

Refs #5093

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 17, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant