Add permission handling for connections page#2075
Open
alexandrudanpop wants to merge 2 commits intomainfrom
Open
Add permission handling for connections page#2075alexandrudanpop wants to merge 2 commits intomainfrom
alexandrudanpop wants to merge 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds permission-aware UI elements to the Connections page by moving the page header into the route module and wrapping connection actions with a permission guard.
Changes:
- Introduces a
ConnectionsHeadercomponent in the connections route and wires it into the router. - Updates the “New Connection” trigger to be wrapped with
PermissionGuard. - Wraps the per-row “Edit” and “Delete” dropdown actions with
PermissionGuardand removes the old header export from the table module.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/react-ui/src/app/routes/connections/index.tsx | Adds ConnectionsHeader with a permission-guarded “New Connection” trigger and simplifies the page component to only render the table. |
| packages/react-ui/src/app/router.tsx | Switches the connections route header import to the new route-level ConnectionsHeader. |
| packages/react-ui/src/app/features/connections/components/connection-table.tsx | Removes the old ConnectionsHeader and wraps Edit/Delete menu items with PermissionGuard. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
packages/react-ui/src/app/features/connections/components/connection-table.tsx
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes OPS-3681