Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1637 +/- ##
==========================================
- Coverage 52.82% 52.71% -0.11%
==========================================
Files 37 37
Lines 4371 4361 -10
==========================================
- Hits 2309 2299 -10
Misses 2062 2062 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
I think we should keep skipping the tests/files directory. The content there is generated programmatically, and excluding it helps ensure we don't accidentally modify generated artifacts.
Not sure, but after this change it might make sense to adjust pre-commit-config.yaml or pyproject.toml make the skip rule less restrictive.
Also please sync with main, there are some conflicts.
Other than that, the rest of the changes look good to me.
I think Franz was the one who told me to include the |
fixes #1639.
Only major changes in this PR:
ruffversion update from v0.14.10 to v0.15.1mypyversion update from v1.13.0 to v1.19.1mypy(instead of using the suggested approach by @fkiraly to only check for files changed and then chip at it brick-by-brick to fix mypy errors, the architecture of those functions would most likely need to be changed, so if someone was adding a simple test they'd have to fix a ton of errors occuring in that file for other functions, which doesnt make sense)testsdirectory in ruff and mypy checks:ruffwherever possible and addednoqatags to other placesmypy(for the reason mentioned above in point 2)