[MNT] Dockerized tests for CI runs using localhost#1629
[MNT] Dockerized tests for CI runs using localhost#1629satvshr wants to merge 93 commits intoopenml:mainfrom
Conversation
Locally, MinIO already has more parquet files than on the test server.
Note that the previously strategy didn't work anymore if the server returned a parquet file, which is the case for the new local setup.
This means it is not reliant on the evaluation engine processing the dataset. Interestingly, the database state purposely seems to keep the last task's dataset in preparation explicitly (by having processing marked as done but having to dataset_status entry).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1629 +/- ##
==========================================
+ Coverage 52.82% 53.12% +0.29%
==========================================
Files 37 37
Lines 4371 4371
==========================================
+ Hits 2309 2322 +13
+ Misses 2062 2049 -13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The tests are taking too long because |
Will do that to prevent hold ups for other CIs in the repo, for my branch it is noticeable if a run is going to fail if it has been stuck on a single test for more than a minute. |
yeah but each job in this PR still takes full 150 minutes |
geetu040
left a comment
geetu040
left a comment
There was a problem hiding this comment.
I don't think any failing test is coming from this PR. It would be better to conditionally skip them and link #1657. If there is new failure message which is not already mentioned there, then please comment down the failure with the failing tests so it could be tracked there. Also if some tests are failing because of pandas, create a separate issue for that, skip and link to these then.
geetu040
left a comment
geetu040
left a comment
There was a problem hiding this comment.
Looks good, this has not been addressed yet #1629 (comment)
geetu040
left a comment
geetu040
left a comment
There was a problem hiding this comment.
There are so many changes not related to the issue. These must be coming from upgraded pre-commit in your local setting. Can you undo these changes? This PR should touch only the docker related part.
|
The PR looks good, tests are also passing. I will approve this as #1629 (review) is addressed. |
4 participants
Metadata
Details
This PR implements the setting up of the v1 and v2 test servers in CI using docker via
localhost.