Skip to content

Conversation

@joyeecheung
Copy link
Collaborator

No description provided.

@joyeecheung
Copy link
Collaborator Author

joyeecheung commented Oct 8, 2017

I am also raising a PR in the Node core onboarding guide (nodejs/node#16079) that mentions the collaboration summit. Just making sure people are aware of it so they could prepare in advance and attend.

Copy link
Contributor

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Optional nit: Change the comma after travel expenses to a period and make see the beginning of its own sentence.

@joyeecheung
Copy link
Collaborator Author

@Trott Fixed, thanks!

@joyeecheung joyeecheung merged commit 1577c18 into openjs-foundation:master Oct 8, 2017
@joyeecheung
Copy link
Collaborator Author

I assume we use the merge button here. Let me know if I've got it wrong.

@gibfahn
Copy link

gibfahn commented Oct 8, 2017

I assume we use the merge button here. Let me know if I've got it wrong.

The Squash and merge button? I don't think it really matters for this repo, but in general disabling the Merge Pull Request button, and just leaving Squash and Merge and Rebase and Merge seems like a good way to go in repos that aren't nodejs/node.

@joyeecheung
Copy link
Collaborator Author

@gibfahn SGTM, though I am not good enough with Github to know how to do that.

@gibfahn
Copy link

gibfahn commented Oct 8, 2017

@gibfahn SGTM, though I am not good enough with Github to know how to do that.

You'd go to https://github.com/nodejs/summit/settings and untick the Allow merge commits button (leaving the other two ticked), like so:

image

@ljharb
Copy link
Member

ljharb commented Oct 8, 2017

fwiw I always only use the merge commit setting; GitHub's squashmerge and rebasemerge leave orphaned origin/pr/ refs in the git log (if you have enabled fetching of those).

Better is to rebase the fork's branch, push it up, and then merge commit or fast-forward merge (altho it's less convenient)

@joyeecheung
Copy link
Collaborator Author

@gibfahn Done, thanks for the help!

@joyeecheung
Copy link
Collaborator Author

@gibfahn I meant, for this repo. Not quite sure about others, probably best let the owners decide.

@gibfahn
Copy link

gibfahn commented Oct 9, 2017

fwiw I always only use the merge commit setting; GitHub's squashmerge and rebasemerge leave orphaned origin/pr/ refs in the git log (if you have enabled fetching of those).

@ljharb Interesting reason to use merge commits. Does setting git config --global fetch.prune true fix that or does GitHub store them indefinitely (or until the person who raised the PR deletes their branch)?

I just have an alias for fetching PR branches instead of bulk fetching, so I hadn't noticed.

@ljharb
Copy link
Member

ljharb commented Oct 9, 2017

It's stored indefinitely, no matter what happens to the branch, since it's a ref and not a branch.

@gibfahn
Copy link

gibfahn commented Oct 22, 2017

It's stored indefinitely, no matter what happens to the branch, since it's a ref and not a branch.

@ljharb Ah, I see, so they're branches in a different git namespace? I didn't know that was a thing.

Assuming you're using something based on the original Bert Belder gist, it sounds like you can delete PR branches with: https://gist.github.com/piscisaureus/3342247#gistcomment-1763247, no idea if that actually works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants