-
Notifications
You must be signed in to change notification settings - Fork 60
doc: mention travel funds #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I am also raising a PR in the Node core onboarding guide (nodejs/node#16079) that mentions the collaboration summit. Just making sure people are aware of it so they could prepare in advance and attend. |
Trott
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Optional nit: Change the comma after travel expenses to a period and make see the beginning of its own sentence.
|
@Trott Fixed, thanks! |
|
I assume we use the merge button here. Let me know if I've got it wrong. |
The |
|
@gibfahn SGTM, though I am not good enough with Github to know how to do that. |
You'd go to https://github.com/nodejs/summit/settings and untick the |
|
fwiw I always only use the merge commit setting; GitHub's squashmerge and rebasemerge leave orphaned origin/pr/ refs in the git log (if you have enabled fetching of those). Better is to rebase the fork's branch, push it up, and then merge commit or fast-forward merge (altho it's less convenient) |
|
@gibfahn Done, thanks for the help! |
|
@gibfahn I meant, for this repo. Not quite sure about others, probably best let the owners decide. |
@ljharb Interesting reason to use merge commits. Does setting I just have an alias for fetching PR branches instead of bulk fetching, so I hadn't noticed. |
|
It's stored indefinitely, no matter what happens to the branch, since it's a ref and not a branch. |
@ljharb Ah, I see, so they're branches in a different git namespace? I didn't know that was a thing. Assuming you're using something based on the original Bert Belder gist, it sounds like you can delete PR branches with: https://gist.github.com/piscisaureus/3342247#gistcomment-1763247, no idea if that actually works. |

No description provided.