This repository was archived by the owner on Jul 24, 2023. It is now read-only.
Update Auth_OpenID_VERSION #161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the User-Agent improperly reported as `php-openid/2.2.2` via the `Auth_OpenID_USER_AGENT` define
marcoceppi
approved these changes
Nov 20, 2020
Member
marcoceppi
left a comment
marcoceppi
left a comment
There was a problem hiding this comment.
It would be better if this could reflect the version out of composer or something similar. There appears to be a library to do this, for now I'm going to land this and open a followup issue (and make a note during releases to update the version) until we can reflect version from composer itself
Contributor
Author
|
Thanks for the review, merge, and version release! I definitely agree with making this value dynamic instead of static. |
Contributor
Author
|
Hi again @marcoceppi. It looks as though 3.0.3 wasn't released on packagist yet, is that expected? |
Member
|
It's updated, sorry about that! |
Contributor
Author
|
Nice, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the User-Agent improperly reported as
php-openid/2.2.2via theAuth_OpenID_USER_AGENTdefine.I wrote
3.0.3as I imagine a new version is needed to release this.