Merged
Conversation
added 2 commits
January 23, 2019 09:46
Signed-off-by: Ma Shimiao <mashimiao.fnst@cn.fujitsu.com>
Signed-off-by: Ma Shimiao <mashimiao.fnst@cn.fujitsu.com>
zhouhao3
force-pushed
the
add-selinux
branch
6 times, most recently
from
0f241e8 to
cce1a4a
Compare
Signed-off-by: Ma Shimiao <mashimiao.fnst@cn.fujitsu.com> Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
Author
|
@liangchenye PTAL |
Member
|
@q384566678 I'll review it today. |
liangchenye
reviewed
Feb 18, 2019
| if err != nil { | ||
| util.Fatal(err) | ||
| } | ||
| g.SetLinuxMountLabel("system_u:object_r:svirt_sandbox_file_t:s0:c715,c811") |
Member
There was a problem hiding this comment.
We need an 'invalid mount label' test case as well.
Member
|
LGTM As commented, We need an 'invalid mount label' test case as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #386
This is a rebase of #386
Signed-off-by: Ma Shimiao mashimiao.fnst@cn.fujitsu.com
Signed-off-by: Zhou Hao zhouhao@cn.fujitsu.com