Conversation
For specifying device cgroups independent of device creation. I also split the cgroups section into sections for each class (the earlier docs were very terse). I'll flesh these sections out in future commits if the devices addition sounds acceptable. Signed-off-by: W. Trevor King <wking@tremily.us>
I'd prefer to handle mknod and device cgroups independently [1,2], to avoid all this "If path is given..." and "If parameters is given..." special casing. But the overloaded approach has landed [3], so this commit documents the indended semantics [4]. I'm not sure how bundle authors are supposed to register deny cgroups rules [5]. [1]: opencontainers#98 [2]: opencontainers#99 [3]: opencontainers#94 (comment) [4]: opencontainers#94 (comment) [5]: opencontainers#94 (comment) Signed-off-by: W. Trevor King <wking@tremily.us>
|
I was hunting around for the device docs to link today, and was surprised to find them in the |
|
I think this one can be closed now that we already have a Device struct and fields documented. |
|
On Fri, Sep 25, 2015 at 01:45:09PM -0700, Michael Crosby wrote:
Not really documented, see #101 ;). I still think the separation |
I filed a PR to keep this separate [1], but it was closed after [2] landed. See also [3], where I point out that putting the mknod stuff in the “control groups” section is awkward. [1]: opencontainers/runtime-spec#99 Add linux.resources.devices [2]: opencontainers/runtime-spec#94 Replace Linux.Device with more specific config [3]: opencontainers/runtime-spec#171 (comment) move the description of user ns mapping and default files to proper file
This cherry-picks the device-cgroup commit from #98, since I think the
approach is useful regardless of how we're creating the devices.