implementations: add bwrap-oci and crun#929
Merged
tianon merged 2 commits intoopencontainers:masterfrom Oct 23, 2017
Merged
Conversation
|
LGTM |
wking
suggested changes
Oct 16, 2017
| [oct]: https://github.com/huawei-openlab/oct | ||
| [runtime-tools]: https://github.com/opencontainers/runtime-tools | ||
| [bwrap-oci]: https://github.com/projectatomic/bwrap-oci | ||
| [crun]: https://github.com/giuseppe/crun |
Contributor
There was a problem hiding this comment.
These are link label definitions, but you also need to add reference-style links to consume the definitions (like this).
Member
Author
There was a problem hiding this comment.
@wking thanks. I've pushed a corrected version
giuseppe
force-pushed
the
add-more-implementations
branch
from
c1311c4 to
9162f13
Compare
wking
reviewed
Oct 16, 2017
implementations.md
Outdated
| ## <a name="implementationsRuntimeContainer" />Runtime (Container) | ||
|
|
||
| * [opencontainers/runc][runc] - Reference implementation of OCI runtime | ||
| * [projectatomic/bwrap-oci][bwrap-oci]: - Convert the OCI spec file to a command line for [bubblewrap](https://github.com/projectatomic/bubblewrap/) |
Contributor
There was a problem hiding this comment.
The runc line above uses a - separator, while the lines you're adding use : - . I think you want to drop the colon.
giuseppe
force-pushed
the
add-more-implementations
branch
from
9162f13 to
490091f
Compare
wking
approved these changes
Oct 19, 2017
Contributor
wking
left a comment
wking
left a comment
There was a problem hiding this comment.
Looks good to me, although I'd also be fine with a reference-style link for bubblewrap.
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
add-more-implementations
branch
from
490091f to
ec4cc47
Compare
Member
Author
|
@wking I've changed bubblewrap to be a reference-style link |
wking
approved these changes
Oct 22, 2017
Contributor
|
LGTM |
1 similar comment
Member
|
LGTM |
wking
added a commit
to wking/opencontainer-runtime-spec
that referenced
this pull request
Oct 24, 2017
Through a5276ae (Merge pull request opencontainers#929 from giuseppe/add-more-implementations, 2017-10-23). There have also been a few non-spec changes which I have not documented in the ChangeLog: 13b4639 .pullapprove.yml: Switch to v2 and other project-template updates (opencontainers#902) f6f2514 README: Make meetings monthly (were weekly) (opencontainers#910) e27acdd implementations: Replace "cc-oci-runtime" with "cc-runtime" (opencontainers#922) ec4cc47 implementations: add crun (opencontainers#929) d4990d1 implementations: add bwrap-oci (opencontainers#929) 8a16f08 .mailmap: Consolidate James' entries (opencontainers#924) Signed-off-by: W. Trevor King <wking@tremily.us>
Merged
vbatts
pushed a commit
to vbatts/oci-runtime-spec
that referenced
this pull request
Oct 30, 2017
Through a5276ae (Merge pull request opencontainers#929 from giuseppe/add-more-implementations, 2017-10-23). There have also been a few non-spec changes which I have not documented in the ChangeLog: 13b4639 .pullapprove.yml: Switch to v2 and other project-template updates (opencontainers#902) f6f2514 README: Make meetings monthly (were weekly) (opencontainers#910) e27acdd implementations: Replace "cc-oci-runtime" with "cc-runtime" (opencontainers#922) ec4cc47 implementations: add crun (opencontainers#929) d4990d1 implementations: add bwrap-oci (opencontainers#929) 8a16f08 .mailmap: Consolidate James' entries (opencontainers#924) Signed-off-by: W. Trevor King <wking@tremily.us>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.