Conversation
schema/README.md
Outdated
|
|
||
| The layout of the files is as follows: | ||
| * schema.json - the primary entrypoint for the whole schema document | ||
| * schema-linux.json - this schema is for the Linux specific sub structure |
There was a problem hiding this comment.
“Linux-specific sub-structures”?
schema/README.md
Outdated
| * defs.json - definitions for general types | ||
| * defs-linux.json - definitions for Linux-specific types | ||
| * validate.go - validation utility source code | ||
|
|
5bba104 to
f040e1f
Compare
|
f040e1f looks good to me.
|
|
LGTM |
schema/README.md
Outdated
| validating the `config.json` of this container runtime specification. | ||
|
|
||
| The layout of the files is as follows: | ||
| * schema.json - the primary entrypoint for the whole schema document |
There was a problem hiding this comment.
nit: add links to these files
|
Super helpful. Thanks for this PR @vbatts !! LGTM |
schema/README.md
Outdated
| validating the `config.json` of this container runtime specification. | ||
|
|
||
| The layout of the files is as follows: | ||
| * [schema.json](./schema.json) - the primary entrypoint for the whole schema document |
There was a problem hiding this comment.
Pedantic nit: the other link targets don't have a leading ./, so maybe remove this one for consistency?
There was a problem hiding this comment.
muscle memory. fixed.
On Wed, Apr 13, 2016 at 1:43 PM, W. Trevor King notifications@github.com
wrote:
In schema/README.md
#360 (comment)
:@@ -0,0 +1,32 @@
+# JSON schema
+
+## Overview
+
+This directory contains the JSON Schema for
+validating theconfig.jsonof this container runtime specification.
+
+The layout of the files is as follows:
+* schema.json - the primary entrypoint for the whole schema documentPedantic nit: the other link targets don't have a leading ./, so maybe
remove this one for consistency?—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/opencontainers/runtime-spec/pull/360/files/57d2484193eb1631c186f308cf65c1f0fac43952#r59592283
Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
Signed-off-by: Vincent Batts vbatts@hashbangbash.com