Appropriately mark optional fields as omitempty#283
Merged
vbatts merged 2 commits intoopencontainers:masterfrom Jan 4, 2016
Merged
Appropriately mark optional fields as omitempty#283vbatts merged 2 commits intoopencontainers:masterfrom
vbatts merged 2 commits intoopencontainers:masterfrom
Conversation
Signed-off-by: Jonathan Boulle <jonathanboulle@gmail.com>
Contributor
|
LGTM |
Contributor
|
Oh, one other item I forgot about that should be |
Contributor
|
@arcnmx Thanks, @jonboulle Can you update for that? Thanks. |
Contributor
Author
|
done On Wed, Dec 30, 2015 at 2:16 AM, Qiang Huang notifications@github.com
|
Contributor
|
@jonboulle You need to sign your commit. |
Signed-off-by: Jonathan Boulle <jonathanboulle@gmail.com>
Contributor
Author
|
Sigh. Done. On Thu, Dec 31, 2015 at 12:15 PM, Qiang Huang notifications@github.com
|
Contributor
|
Thanks, still LGTM. |
Member
|
LGTM |
vbatts
added a commit
that referenced
this pull request
Jan 4, 2016
Appropriately mark optional fields as omitempty
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jonathan Boulle jonathanboulle@gmail.com
per #282 (comment)