Skip to content

change the name of struct blockIODevice to BlockIODevice#232

Closed
wangkirin wants to merge 1 commit intoopencontainers:masterfrom
wangkirin:master
Closed

change the name of struct blockIODevice to BlockIODevice#232
wangkirin wants to merge 1 commit intoopencontainers:masterfrom
wangkirin:master

Conversation

@wangkirin
Copy link
Copy Markdown

the struct blockIODevice is begin with lower case letters, and we cannot export it and instantiate it from other packages.This PR fixed it

Signed-off-by: Wang Qilin wangqilin2@huawei.com

Signed-off-by: Wang Qilin <wangqilin2@huawei.com>
@runcom
Copy link
Copy Markdown
Member

runcom commented Oct 25, 2015

IIRC I did this way so the inner struct was hidden and you just had to instantiate the upper struct with only the public fields (I explicitly did this way cause I didn't want another struct just for Major, Minor and you can always use the other struct without instantiating the private one). This is to say that unless something really needs it I think exporting this structure is meaningless

@vbatts
Copy link
Copy Markdown
Member

vbatts commented Oct 27, 2015

This is intentional. It'll stay not exported for now.

@vbatts vbatts closed this Oct 27, 2015
@wking
Copy link
Copy Markdown
Contributor

wking commented Mar 2, 2016

On Sun, Oct 25, 2015 at 08:06:35AM -0700, Antonio Murdaca wrote:

IIRC I did this way so the inner struct was hidden and you just had
to instantiate the upper struct with only the public fields…

This got unpacked in more detail on IRC today, starting with 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants