[1.3] fix rootfs propagation mode to shared / unbindable #4789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolyshkin
requested review from
AkihiroSuda,
lifubang and
rata
and removed request for
rata
AkihiroSuda
approved these changes
Jun 20, 2025
Member
|
Hmm, all-done is not marked as ready nor I can re-trigger it. Do you want to push again? Clearly tests didn't run |
Signed-off-by: Yusuke Sakurai <[email protected]> (cherry picked from commit 04be81b) Signed-off-by: Kir Kolyshkin <[email protected]>
Member
In fact, this raises a question: Do we need to backport any bug fixes to the release-1.2 branch? |
lifubang
approved these changes
Jun 20, 2025
Member
|
@lifubang yes, we said we will be quite liberals with backporting to n-1. I think we should :) |
Member
|
1.2 PR: #4791 |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #4724 to release-1.3 branch. Original description follows.
This PR adds support for applying mount propagation settings (MS_SHARED or MS_UNBINDABLE) to the container root based on the value of config.RootPropagation.
We apply mount propagation after executing pivot_root and rootfsParentMountPrivate
Fixes #1755
Related:
#1815
youki-dev/youki#3141
Signed-off-by: Yusuke Sakurai [email protected]