libctr: Reset the inherited cpu affinity #4041
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haircommander
force-pushed
the
cpu-affinity-reset
branch
3 times, most recently
from
f96de14 to
cad71a0
Compare
kolyshkin
reviewed
Sep 28, 2023
haircommander
force-pushed
the
cpu-affinity-reset
branch
2 times, most recently
from
22c6427 to
902a7da
Compare
Contributor
|
nit: you can also add |
haircommander
force-pushed
the
cpu-affinity-reset
branch
2 times, most recently
from
c06381c to
d946178
Compare
Old kernels do that automatically, but new kernels remember the affinity that was set before the cgroup move due to https://lore.kernel.org/lkml/[email protected] This is undesirable for containers, because they inherit the systemd affinity when the should really move to the container space cpus. see https://issues.redhat.com/browse/OCPBUGS-15102 for more information Co-authored-by: Martin Sivak <[email protected]> Signed-off-by: Peter Hunt <[email protected]>
haircommander
force-pushed
the
cpu-affinity-reset
branch
from
d946178 to
66ff048
Compare
Contributor
|
@haircommander is this still a draft? |
Contributor
|
AFAIK this relies on the kernel patch which is still not merged: https://lore.kernel.org/lkml/[email protected]/ (@haircommander please correct me if I'm wrong) |
Contributor
Author
|
correct! still a draft for that reason |
Closed
Member
|
Actually the sched patches were merged in Linux 6.2 (torvalds/linux@bf57ae2) but this PR won't actually work, for the reasons I explain in #4858 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old kernels do that automatically, but new kernels remember the affinity that was set before the cgroup move due to
https://lore.kernel.org/lkml/[email protected]
This is undesirable for containers, because they inherit the systemd affinity when the should really move to the container space cpus.
Draft as the required patch set is not yet merged upstream