Skip to content

Bugfix/#43 fix controller restart on config change#104

Merged
DivineThreepwood merged 6 commits intodevfrom
bugfix/#43_fix_controller_restart_on_config_change
Aug 1, 2023
Merged

Bugfix/#43 fix controller restart on config change#104
DivineThreepwood merged 6 commits intodevfrom
bugfix/#43_fix_controller_restart_on_config_change

Conversation

@DivineThreepwood
Copy link
Copy Markdown
Member

📜 Description

Changes proposed in this pull request:

  • fix re-instating CoroutineScope on activate in RPCServerImpl

scope: Scope,
config: CommunicatorConfig,
dispatcher: CoroutineDispatcher? = GlobalCachedExecutorService.getInstance().executorService.asCoroutineDispatcher()
private val dispatcher: CoroutineDispatcher? = GlobalCachedExecutorService.getInstance().executorService.asCoroutineDispatcher(),

Check warning

Code scanning / detekt

Line detected that is longer than the defined maximum line length in the code style.

Line detected that is longer than the defined maximum line length in the code style.
Copy link
Copy Markdown
Member Author

@DivineThreepwood DivineThreepwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from my side everything is fine.

@lhuxohl lhuxohl removed their assignment Aug 1, 2023
@DivineThreepwood DivineThreepwood merged commit f1c3e42 into dev Aug 1, 2023
@DivineThreepwood DivineThreepwood deleted the bugfix/#43_fix_controller_restart_on_config_change branch August 1, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants