Merged
Conversation
DivineThreepwood
requested changes
Oct 4, 2022
Member
DivineThreepwood
left a comment
DivineThreepwood
left a comment
There was a problem hiding this comment.
Minor clarification requested.
Comment on lines
+20
to
+29
| private fun isFailed(future: AbstractAuthenticationFuture<*, *>): Boolean { | ||
| try { | ||
| // Note: the abstract authentication future will remove itself from this list if | ||
| // get finished successfully. | ||
| future.get(FUTURE_TIMEOUT_IN_MS, TimeUnit.MILLISECONDS) | ||
| } catch (ex: ExecutionException) { | ||
| return true | ||
| } | ||
| return false | ||
| } |
Member
There was a problem hiding this comment.
How do you want to behave in case an TimeoutException occurs? You want to return false right? However, its not handled here and therefore the function will rethrow the TimeoutException which will lead to no further future checks of the other elements in the authenticatedFutureList.
Contributor
Author
There was a problem hiding this comment.
Yes, you are right. I just updated this.
DivineThreepwood
approved these changes
Oct 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Changes proposed in this pull request: