Skip to content

implement caching of unit configs by type #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DivineThreepwood merged 1 commit into from
Apr 4, 2023
Merged

implement caching of unit configs by type #109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 20 additions & 15 deletions ...gistry/core/src/main/java/org/openbase/bco/registry/unit/core/UnitRegistryController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,10 @@
import org.openbase.bco.registry.unit.core.consistency.sceneconfig.SceneServiceStateConsistencyHandler;
import org.openbase.bco.registry.unit.core.consistency.sceneconfig.ServiceStateDescriptionHierarchyConsistencyHandler;
import org.openbase.bco.registry.unit.core.consistency.unitgroupconfig.*;
import org.openbase.bco.registry.unit.core.consistency.userconfig.*;
import org.openbase.bco.registry.unit.core.consistency.userconfig.UserConfigLanguageConsistencyHandler;
import org.openbase.bco.registry.unit.core.consistency.userconfig.UserConfigUserNameConsistencyHandler;
import org.openbase.bco.registry.unit.core.consistency.userconfig.UserPermissionConsistencyHandler;
import org.openbase.bco.registry.unit.core.consistency.userconfig.UserUnitLabelConsistencyHandler;
import org.openbase.bco.registry.unit.core.plugin.*;
import org.openbase.bco.registry.unit.lib.UnitRegistry;
import org.openbase.bco.registry.unit.lib.auth.AuthorizationWithTokenHelper;
Expand Down Expand Up @@ -193,6 +196,22 @@ protected void postInit() throws InitializationException, InterruptedException {
}
}

@Override
public void activate() throws InterruptedException, CouldNotPerformException {
this.addDataObserver(clearUnitConfigsByTypeObserver);
CachedTemplateRegistryRemote.getRegistry().addDataObserver(clearUnitConfigsByTypeObserver);

super.activate();
}

@Override
public void deactivate() throws InterruptedException, CouldNotPerformException {
this.removeDataObserver(clearUnitConfigsByTypeObserver);
CachedTemplateRegistryRemote.getRegistry().removeDataObserver(clearUnitConfigsByTypeObserver);

super.deactivate();
}

/**
* {@inheritDoc}
*/
Expand Down Expand Up @@ -553,9 +572,7 @@ public UnitConfig getUnitConfigById(final String unitConfigId) throws NotAvailab
* {@inheritDoc}
*
* @param unitAlias {@inheritDoc}
*
* @return {@inheritDoc}
*
* @throws NotAvailableException {@inheritDoc}
*/
@Override
Expand All @@ -577,9 +594,7 @@ public UnitConfig getUnitConfigByAlias(final String unitAlias) throws NotAvailab
*
* @param unitAlias {@inheritDoc}
* @param unitType {@inheritDoc}
*
* @return {@inheritDoc}
*
* @throws NotAvailableException {@inheritDoc}
*/
@Override
Expand Down Expand Up @@ -659,9 +674,7 @@ public Future<AuthenticatedValue> removeUnitConfigAuthenticated(final Authentica
* {@inheritDoc}
*
* @param filterDisabledUnits {@inheritDoc}
*
* @return {@inheritDoc}
*
* @throws CouldNotPerformException {@inheritDoc}
* @throws NotAvailableException {@inheritDoc}
*/
Expand All @@ -685,7 +698,6 @@ public List<UnitConfig> getUnitConfigsFiltered(boolean filterDisabledUnits) thro
* {@inheritDoc}
*
* @return {@inheritDoc}
*
* @throws CouldNotPerformException {@inheritDoc}
*/
@Override
Expand All @@ -697,7 +709,6 @@ public List<UnitConfig> getDalUnitConfigs() throws CouldNotPerformException {
* {@inheritDoc}
*
* @return {@inheritDoc}
*
* @throws CouldNotPerformException {@inheritDoc}
*/
@Override
Expand Down Expand Up @@ -748,9 +759,7 @@ public Boolean isUnitGroupConfigRegistryConsistent() {
* {@inheritDoc}
*
* @param serviceType
*
* @return
*
* @throws CouldNotPerformException
*/
@Override
Expand All @@ -771,9 +780,7 @@ public List<ServiceConfig> getServiceConfigsByServiceType(final ServiceType serv
*
* @param unitType
* @param serviceTypes
*
* @return
*
* @throws CouldNotPerformException
*/
@Override
Expand Down Expand Up @@ -1041,7 +1048,6 @@ protected UnitRegistryData filterDataForUser(final UnitRegistryData.Builder data
* {@inheritDoc}
*
* @param authorizationToken {@inheritDoc}
*
* @return {@inheritDoc}
*/
@Override
Expand All @@ -1060,7 +1066,6 @@ public Future<String> requestAuthorizationToken(final AuthorizationToken authori
* {@inheritDoc}
*
* @param authenticatedValue {@inheritDoc}
*
* @return {@inheritDoc}
*/
@Override
Expand Down
Loading