Merged
Conversation
Closed
DivineThreepwood
approved these changes
Feb 6, 2023
Member
DivineThreepwood
left a comment
DivineThreepwood
left a comment
There was a problem hiding this comment.
Thanks for the upgrade. Code is approved. Just two open conversations.
DivineThreepwood
added
ready to test
code approved
tested
ready to merge
and removed
ready to review
ready to test
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Changes proposed in this pull request:
I tested this locally by starting
bco-testand accessinglocalhostwith the flutter webapp. It did not work before these changes.Most of the changes to the code had to be done because the
GraphQLContextwas replaced byGraphQLKickstartContextin the new java graphql version.